[
https://issues.apache.org/jira/browse/MAPREDUCE-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940021#comment-14940021
]
Akira AJISAKA commented on MAPREDUCE-6496:
------------------------------------------
Mostly looks good to me.
{code}
+ * If the first byte value v is between -113 and -120, the following integer
+ * is positive, with number of bytes that follow are -(v+112).
+ * If the first byte value v is between -121 and -128, the following integer
+ * is negative, with number of bytes that follow are -(v+120). Bytes are
{code}
If v is int, I'm thinking v is between -113 and -116, or between -121 and -124.
> Incorrect javadoc in WritableUtils.java
> ---------------------------------------
>
> Key: MAPREDUCE-6496
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6496
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.7.1
> Reporter: Martin Petricek
> Assignee: Jagadesh Kiran N
> Priority: Minor
> Attachments: MAPREDUCE-6496-00.patch
>
>
> Documentation for writeVLong in WritableUtils states that "For
> -112 <= i <= 127, only one byte is used"
> Documentation for writeVInt states that "For -120 <= i <= 127, only one byte
> is used"
> writeVInt calls internally writeVLong, so the ranges are the same for both
> functions.
> After examining the code, I see that the documentation that is at writeVLong
> is correct.
> Documentation for writeVInt is therefore incorrect and should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)