[
https://issues.apache.org/jira/browse/MAPREDUCE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000204#comment-15000204
]
Akira AJISAKA commented on MAPREDUCE-6499:
------------------------------------------
Mostly looks good to me. Minor nits:
{code}
+ * Given the time in long milliseconds, returns a String in the format Xhrs,
+ * Ymins, Z sec with a sortable format, if hour is 0,it will be add 00, and
if
+ * the time is more than 99 hours ,it will be show 99hrs, 59mins, 59seconds.
{code}
bq. returns a String in the format Xhrs, Ymins, Z sec with a sortable format,
"format" and "sortable format" is redundant. It can be simplified as "returns a
String in the sortable format Xhrs, Ymins, Zsec."
bq. if hour is 0, it will be add 00,
Zero padding is applied not only to hour but also to min and sec, so "if hour
is 0,it will be add 00" can be rewrittened as "X, Y, and Z are always
two-digit."
bq. if the time is more than 99 hours, it will be show 99hrs, 59mins, 59seconds.
* 99 should be 100 because 99 hours and 40 mins is more than 99 hours but it is
displayed as "99hrs, 40mins, 00sec."
* "it will be show 99hrs, 59mins, 59seconds." -> "it is displayed as 99hrs,
59mins, 59sec."
> Add More Informations Of Jobs In JobHistory Main Page
> -----------------------------------------------------
>
> Key: MAPREDUCE-6499
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6499
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Priority: Trivial
> Attachments: HADOOP-MAPREDUCE-6499.2.patch,
> HADOOP-MAPREDUCE-6499.3.patch, HADOOP-MAPREDUCE-6499.4.patch,
> HADOOP-MAPREDUCE-6499.5.patch, HADOOP-MAPREDUCE-6499.6.patch,
> HADOOP-MAPREDUCE-6499.7.patch, HADOOP-MAPREDUCE-6499.8.patch,
> HADOOP-MAPREDUCE-6499.patch
>
>
> Now in JobHistory Main Page show too little information about finished
> jobs,even don't have the job's running total time,only
> startTime,finishedTime.So,in jobHistory main page,we can add more
> informations about jobs, that we can better analyze jobs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
