[
https://issues.apache.org/jira/browse/MAPREDUCE-6688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265752#comment-15265752
]
Naganarasimha G R commented on MAPREDUCE-6688:
----------------------------------------------
Hi [~varun_saxena],
Earlier when we had discussed the solution offline i did not get the complete
picture but after putting more thought on it and seeing your patch, had my
reservations on the approach which i mentioned
{{HistoryEvent.getTimelineEntitiesToPublish}}, In my view overall design across
the history events seems to have specific modifications which are required for
JobFinished and JobSubmitted Event. Also if we plan to push later through RM
then i am not sure we will try to push events from EventHandler to RM. And also
configuration would be difficult to understand to the user as it considers the
implementation specific logic.
Even if we take [~gtCarrera9]'s approach {{HistoryEvent.addDataToEntity}} will
also have its own set of issues.
So, IMO if its important to capture configuration as part of System Entities
and if its important split the configs then i am fine with the current approach
provided if others are ok to refactor it again based on the approach taken in
YARN-3401.
> Store job configurations in Timeline Service v2
> -----------------------------------------------
>
> Key: MAPREDUCE-6688
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6688
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: applicationmaster
> Affects Versions: YARN-2928
> Reporter: Junping Du
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: MAPREDUCE-6688-YARN-2928.01.patch,
> YARN-3959-YARN-2928.01.patch
>
>
> We already have configuration field in HBase schema for application entity.
> We need to make sure AM write it out when it get launched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
