[ https://issues.apache.org/jira/browse/MAPREDUCE-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389209#comment-15389209 ]
Brahma Reddy Battula commented on MAPREDUCE-6682: ------------------------------------------------- [~ajisakaa] thanks for working on this issue and pinging me.. Approach overall looks great. Some minor nits: 1) *{{TestMRCJCFileOutputCommitter}}:* As {{testCommitter}} also calling {{FileUtil.fullyDelete(new File(outDir.toString()))}} at the end of testcase,how about adding in teardown..? 2) *{{TestMRTimelineEventHandling}}:* do we need to handle {{inDir}} delete also..? > TestMRCJCFileOutputCommitter fails intermittently > ------------------------------------------------- > > Key: MAPREDUCE-6682 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6682 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test > Reporter: Brahma Reddy Battula > Assignee: Akira Ajisaka > Attachments: MAPREDUCE-6682.00.patch, MAPREDUCE-6682.01.patch, > MAPREDUCE-6682.02.patch > > > {noformat} > java.lang.AssertionError: Output directory not empty expected:<0> but was:<4> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at > org.apache.hadoop.mapred.TestMRCJCFileOutputCommitter.testAbort(TestMRCJCFileOutputCommitter.java:153) > {noformat} > *PreCommit Report* > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6434/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org