[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783953#comment-15783953 ]
Daniel Templeton commented on MAPREDUCE-6715: --------------------------------------------- Thanks, [~yufeigu]. Some comments: * In {{CleanupQueue}}, you're missing a space in the text at the line break * In {{ShuffleSchedulerImpl}}, the {{LOG.debug()}} should be in a conditional * In {{MapTask}} if you return {{null}}, you're going to cause NPEs > Fix Bad Practices > ----------------- > > Key: MAPREDUCE-6715 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6715 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 2.9.0 > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: MAPREDUCE-6715.001.patch, MAPREDUCE-6715.002.patch > > > {code} > Null Dereference CleanupQueue.java:139 > Weak SecurityManager Check: Overridable Method > LocalDistributedCacheManager.java:229 > Null Dereference TextOutputFormat.java:137 > Null Dereference ShuffleSchedulerImpl.java:422 > Null Dereference MapTask.java:415 > Null Dereference Pentomino.java:160 > Unreleased Resource: Streams TeraScheduler.java:77 > Unreleased Resource: Streams CLI.java:570 > Null Dereference CLI.java:370 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org