[ https://issues.apache.org/jira/browse/MAPREDUCE-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043574#comment-16043574 ]
Junping Du commented on MAPREDUCE-6895: --------------------------------------- The patch LGTM as well. The only minor comments is: MRJobConfig.MR_JOB_END_NOTIFICATION_URL get duplicated checked - by shutdownJob() and notifier.notify(report). Given shutdownJob is the only non-test place to call notifier.notify(report), we can omit one check I think. Other looks fine. > Job end notification not send due to YarnRuntimeException > --------------------------------------------------------- > > Key: MAPREDUCE-6895 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6895 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: applicationmaster > Affects Versions: 2.4.1, 2.8.0, 2.7.3 > Reporter: yunjiong zhao > Assignee: yunjiong zhao > Attachments: MAPREDUCE-6895.001.patch > > > MRAppMaster.this.stop() throw out YarnRuntimeException as below log shows, it > caused job end notification not send. > {quote} > 2017-05-24 12:14:02,165 WARN [Thread-693] > org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Graceful stop failed > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: > java.nio.channels.ClosedChannelException > at > org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.handleEvent(JobHistoryEventHandler.java:531) > at > org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:360) > at > org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221) > at > org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52) > at > org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80) > at > org.apache.hadoop.service.CompositeService.stop(CompositeService.java:157) > at > org.apache.hadoop.service.CompositeService.serviceStop(CompositeService.java:131) > at > org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStop(MRAppMaster.java:1476) > at > org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221) > at > org.apache.hadoop.mapreduce.v2.app.MRAppMaster.stop(MRAppMaster.java:1090) > at > org.apache.hadoop.mapreduce.v2.app.MRAppMaster.shutDownJob(MRAppMaster.java:554) > at > org.apache.hadoop.mapreduce.v2.app.MRAppMaster$JobFinishEventHandler$1.run(MRAppMaster.java:605) > Caused by: java.nio.channels.ClosedChannelException > at > org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:1528) > at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:98) > at > org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:58) > at java.io.DataOutputStream.write(DataOutputStream.java:107) > at > org.codehaus.jackson.impl.Utf8Generator._flushBuffer(Utf8Generator.java:1754) > at > org.codehaus.jackson.impl.Utf8Generator.flush(Utf8Generator.java:1088) > at org.apache.avro.io.JsonEncoder.flush(JsonEncoder.java:67) > at > org.apache.hadoop.mapreduce.jobhistory.EventWriter.write(EventWriter.java:67) > at > org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler$MetaInfo.writeEvent(JobHistoryEventHandler.java:886) > at > org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.handleEvent(JobHistoryEventHandler.java:520) > ... 11 more > 2017-05-24 12:14:02,165 INFO [Thread-693] > org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Exiting MR AppMaster..GoodBye! > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org