[
https://issues.apache.org/jira/browse/MAPREDUCE-6838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132092#comment-16132092
]
Varun Saxena commented on MAPREDUCE-6838:
-----------------------------------------
bq. Why are changing hadoop-common code to ignore ignoreUseIpConfig? Is this
because to add test case? Does test is failing?
As discussed offline, this is to ensure that token service resolution is in
sync between NM and AM. Also, with default configurations, E2E flow won't work.
bq. I think it is better to update token on each heart beat rather then
comparing each time. It avoids proto compare.
This would involve iterating over all the tokens on each HB when we add token
to UGI. Infact depending on how many tokens a AM has in UGI, this may be even
more expensive.
bq. This appears mixing collectorManager i.e NMCollectorService authentication
and MR side.
The latest patch file contains code from YARN-7006. I used a dummy patch just
to ensure QA runs. Will delete that patch as YARN-7006 has gone in.
bq. One thing I observe is TimelineClient is published using login user which
is doAS. I think we should publish is as owner of application otherwise we end
up in writing data into sub app application table as well.
Fair point. We can raise a separate JIRA for this. And create a proxy user
based on app user to ensure timeline client publishes with that.
bq. I just noticed that TimelineDelegationTokenIdentifier#Renewer has methods
renew/cancel. These creates V1 client. Does it going to be a problem?
This is not used by us for V2 anywhere and the Renewer class is annotated as
Private. I guess no client would explicitly call it and even if they do, it
should fail.
> [ATSv2 Security] Add timeline delegation token received in allocate response
> to UGI
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6838
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6838
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: MAPREDUCE-6838-YARN-5355.01.patch,
> MAPREDUCE-6838-YARN-5355.02.patch, MAPREDUCE-6838-YARN-5355.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
