[
https://issues.apache.org/jira/browse/MAPREDUCE-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166857#comment-16166857
]
Robert Kanter commented on MAPREDUCE-6954:
------------------------------------------
Almost there:
# I'm not a fan of double negatives in booleans - they make things hard to
read. I understand what you're doing here, relying on the default value to be
true instead of setting it (that's a good idea btw), but instead of using
{{!shouldBeDisabled}} let's use {{default}} instead. That's much easier to
follow.
#- In a similar vein, let's rename {{testErasureCodingNotDisabled}} to
{{testErasureCodingDefault}}.
# There's some new checkstyle warnings about indenting and line length.
> Disable erasure coding for files that are uploaded to the MR staging area
> -------------------------------------------------------------------------
>
> Key: MAPREDUCE-6954
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6954
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0-alpha4
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Attachments: MAPREDUCE-6954-001.patch, MAPREDUCE-6954-002.patch
>
>
> Depending on the encoder/decoder used and the type or MR workload, EC might
> negatively affect the performance of an MR job if too many files are
> localized.
> In such a scenario, users might want to disable EC in the staging area to
> speed up the execution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
