[
https://issues.apache.org/jira/browse/MAPREDUCE-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703566#comment-16703566
]
Wangda Tan commented on MAPREDUCE-7167:
---------------------------------------
[~saurabhpant], thanks for filing the JIRA.
Could u upload job history file before and after the patch? jhist file is a
public contract between MR app and other metrics monitoring frameworks. Even if
there're extra line breaks inside the file, removing such things could be
considered as an incompatible change. So if you could upload files after the
patch applied, it gonna be very helpful.
And btw please don't set fix version, that is used by committer once the patch
got committed.
If you could provide your JIRA id, I can add you to contributors list.
> Extra LF ("\n") pushed directly to storage
> ------------------------------------------
>
> Key: MAPREDUCE-7167
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7167
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Saurabh
> Priority: Major
> Attachments: image-2018-11-28-19-23-52-972.png, patch1128.patch,
> patch1128.patch, patch1128trunk.patch
>
>
> JsonEncoder already adds the necessary newline after writing each object as
> per [this|
> [https://github.com/apache/avro/blob/39ec1a3f0addfce06869f705f7a17c03d538fe16/lang/java/avro/src/main/java/org/apache/avro/io/JsonEncoder.java#L77]
> ] so this patch removes the "out.writeBytes("\n");". As the encoder is
> buffered, the out.writeBytes can cause JSON errors in the output stream as it
> directly writes to the output stream, hence it must be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
