[ https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902809#comment-16902809 ]
Adam Antal commented on MAPREDUCE-7197: --------------------------------------- Uploaded patch v6 which fixes the test problems, and hopefully the ASF license alert as well. The rest of the checkstyle stems from the misindentation of whole files ({{TestStagingCleanup.java}}, {{TestMultiFileSplit.java}}). I would not reindent those as that would unnecessary generate mess in the git history. > Fix order of actual and expected expression in assert statements > ---------------------------------------------------------------- > > Key: MAPREDUCE-7197 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 3.2.0 > Reporter: Adam Antal > Assignee: Adam Antal > Priority: Major > Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, > MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, MAPREDUCE-7197.004.patch, > MAPREDUCE-7197.005.patch, MAPREDUCE-7197.006.patch, > old-approx-from-HADOOP-12693 > > > Fix order of actual and expected expression in assert statements which gives > misleading message when test case fails. Attached file has some of the places > where it is placed wrongly. > {code:java} > [ERROR] > testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService) > Time elapsed: 3.385 s <<< FAILURE! > java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but > was:<0> > {code} > For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be > used for new test cases which avoids such mistakes. > This is a follow-up Jira on the fix for the MR project. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org