[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7270?focusedWorklogId=562115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562115
 ]

ASF GitHub Bot logged work on MAPREDUCE-7270:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Mar/21 04:25
            Start Date: 08/Mar/21 04:25
    Worklog Time Spent: 10m 
      Work Description: sungpeo commented on a change in pull request #1942:
URL: https://github.com/apache/hadoop/pull/1942#discussion_r589162197



##########
File path: 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java
##########
@@ -43,6 +46,19 @@
 
   private final String LINE_SEPARATOR = System.lineSeparator();
 
+  private static Locale DEFAULT_LOCALE;

Review comment:
       @liuml07 
   I think the static DEFAULT_LOCALE which could be stale during other test 
suites or settings,
    because, the DEFAULT_LOCALE will be set before all of the tests.
   
   What do you think about?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 562115)
    Remaining Estimate: 0h
            Time Spent: 10m

> TestHistoryViewerPrinter could be failed when the locale isn't English.
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7270
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7270
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Sungpeo Kook
>            Priority: Minor
>         Attachments: MAPREDUCE-7270.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Both of testHumanPrinter and testHumanPrinterAll have expected string for 
> assertion.
> But the actual result includes the Dateformat which can be different depends 
> on Locale.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to