[
https://issues.apache.org/jira/browse/MAPREDUCE-7322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299031#comment-17299031
]
Jim Brennan commented on MAPREDUCE-7322:
----------------------------------------
Great work [~ahussein]. Overall this looks excellent. Just a few minor comments:
GenericTestUtils
* I’m not sure why we need convertCamelToHyphen(). I can understand that the
directory names would be more readable, but they would no longer match the test
case method name, making it harder to match up the test dirs with the test
cases? Am I missing something?
* The methods relating to initializing spill encryption configs do not belong
in Common. These need to be somewhere in the MAPREDUCE project.
initEncryptedIntermediateConfigs(), setLocalDirectoriesConfig()
MapTask
* remove TODO comment (as you noted)
TestGenericTestUtils
* not sure about need for testConvertCamelCase() (see above)
> revisiting TestMRIntermediateDataEncryption
> --------------------------------------------
>
> Key: MAPREDUCE-7322
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7322
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: job submission, security, test
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: patch-available
> Attachments: MAPREDUCE-7322.001.patch, MAPREDUCE-7322.002.patch,
> MAPREDUCE-7322.003.patch, MAPREDUCE-7322.004.patch, MAPREDUCE-7322.005.patch
>
>
> I was reviewing {{TestMRIntermediateDataEncryption}}. The unit test has
> actually little to do with encryption.
> I have the following conclusion:
> * Enabling/Disabling {{MRJobConfig.MR_ENCRYPTED_INTERMEDIATE_DATA}} does not
> change the behavior of the unit test.
> * There are no spill files generated by either mappers/reducers
> * Wrapping I/O streams with Crypto never happens during the execution of the
> unit test.
> Unless I misunderstand the purpose of that unit test, I suggest that it gets
> re-implemented so that it validates encryption in spilled intermediate data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
