[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Chen updated MAPREDUCE-7357:
---------------------------------
    Description: 
h2. What is the purpose of this change

This issue is to fix a non-idempotent test
{code:java}
org.apache.hadoop.mapreduce.v2.app.webapp.TestAppController.testAttempt{code}
h2. Why the test failed

The root cause for the failure is that this test does not remove the value of 
key AMParams.ATTEMPT_STATE, which pollutes the shared state. It may be better 
to clean state pollutions so that some other tests won't fail in the future due 
to the shared state polluted by this test.
h2. Reproduce test failure

Run the test twice in the same JVM.
h2. Expected result

The test should run successfully without any failures.
h2. Actual result

Failure from test run:
{code:java}
[ERROR] Failures:
[ERROR] TestAppController.testAttempts:315 expected:<[Bad request: missing 
attempt-state.]> but was:<[State MAP attempts in job_01_01]>{code}
h2. Fix 

Remove the {{AMParams.ATTEMPT_STATE}} key-value pair.

Link to PR:

  was:
h2. What is the purpose of this change

This issue is to fix a non-idempotent test
{code:java}
org.apache.hadoop.mapreduce.v2.app.webapp.TestAppController.testAttempt{code}
h2. Why the test failed

The root cause for the failure is that this test does not remove the value of 
key AMParams.ATTEMPT_STATE, which pollutes the shared state. It may be better 
to clean state pollutions so that some other tests won't fail in the future due 
to the shared state polluted by this test.
h2. Reproduce test failure

Run the test twice in the same JVM.
h2. Expected result

The test should run successfully without any failures.
h2. Actual result

Failure from test run:
{code:java}
[ERROR] Failures:
[ERROR] TestAppController.testAttempts:315 expected:<[Bad request: missing 
attempt-state.]> but was:<[State MAP attempts in job_01_01]>{code}
h2. Fix 

 Remove this key-value pair by
{code:java}
appController.getProperty().remove(AMParams.ATTEMPT_STATE){code}
Link to PR:


> Clean shared state pollution to avoid flaky tests in class TestAppController
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7357
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7357
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Yang Chen
>            Priority: Minor
>
> h2. What is the purpose of this change
> This issue is to fix a non-idempotent test
> {code:java}
> org.apache.hadoop.mapreduce.v2.app.webapp.TestAppController.testAttempt{code}
> h2. Why the test failed
> The root cause for the failure is that this test does not remove the value of 
> key AMParams.ATTEMPT_STATE, which pollutes the shared state. It may be better 
> to clean state pollutions so that some other tests won't fail in the future 
> due to the shared state polluted by this test.
> h2. Reproduce test failure
> Run the test twice in the same JVM.
> h2. Expected result
> The test should run successfully without any failures.
> h2. Actual result
> Failure from test run:
> {code:java}
> [ERROR] Failures:
> [ERROR] TestAppController.testAttempts:315 expected:<[Bad request: missing 
> attempt-state.]> but was:<[State MAP attempts in job_01_01]>{code}
> h2. Fix 
> Remove the {{AMParams.ATTEMPT_STATE}} key-value pair.
> Link to PR:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to