[
https://issues.apache.org/jira/browse/MAPREDUCE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated MAPREDUCE-7382:
-----------------------------
Priority: Critical (was: Major)
> sensitive inform may leak due to crash
> --------------------------------------
>
> Key: MAPREDUCE-7382
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7382
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: lujie
> Priority: Critical
>
> current, we implement processDoneFiles in JobHistoryEventHandler like:
>
>
> {code:java}
> // try {
> String doneSummaryFileName = getTempFileName(JobHistoryUtils
> .getIntermediateSummaryFileName(jobId));
> qualifiedSummaryDoneFile = doneDirFS.makeQualified(new Path(
> doneDirPrefixPath, doneSummaryFileName));
> summaryFileOut = doneDirFS.create(qualifiedSummaryDoneFile, true);
> summaryFileOut.writeUTF(mi.getJobSummary().getJobSummaryString());
> summaryFileOut.close();
> doneDirFS.setPermission(qualifiedSummaryDoneFile, new FsPermission(
> JobHistoryUtils.HISTORY_INTERMEDIATE_FILE_PERMISSIONS));
> } catch (IOException e) {
> LOG.info("Unable to write out JobSummaryInfo to ["
> + qualifiedSummaryDoneFile + "]", e);
> throw e;
> } {code}
>
>
> wihle node crash before setPermission, we may leak SummaryDoneFile.
>
> code should be like:
>
> {code:java}
> try {
> String doneSummaryFileName = getTempFileName(JobHistoryUtils
> .getIntermediateSummaryFileName(jobId));
> qualifiedSummaryDoneFile = doneDirFS.makeQualified(new Path(
> doneDirPrefixPath, doneSummaryFileName));
> summaryFileOut = doneDirFS.create(qualifiedSummaryDoneFile, true);
> doneDirFS.setPermission(qualifiedSummaryDoneFile, new FsPermission(
> JobHistoryUtils.HISTORY_INTERMEDIATE_FILE_PERMISSIONS));
> summaryFileOut.writeUTF(mi.getJobSummary().getJobSummaryString());
> summaryFileOut.close();
>
> } catch (IOException e) {
> LOG.info("Unable to write out JobSummaryInfo to ["
> + qualifiedSummaryDoneFile + "]", e);
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
