[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7391?focusedWorklogId=783787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783787
 ]

ASF GitHub Bot logged work on MAPREDUCE-7391:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jun/22 09:29
            Start Date: 22/Jun/22 09:29
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on code in PR #4472:
URL: https://github.com/apache/hadoop/pull/4472#discussion_r903507980


##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestLocalDistributedCacheManager.java:
##########
@@ -44,22 +45,31 @@
 import org.apache.hadoop.fs.FileStatus;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.FilterFileSystem;
+import org.apache.hadoop.fs.FutureDataInputStreamBuilder;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.fs.PositionedReadable;
 import org.apache.hadoop.fs.Seekable;
+import org.apache.hadoop.fs.impl.FutureDataInputStreamBuilderImpl;
 import org.apache.hadoop.fs.permission.FsPermission;
 import org.apache.hadoop.mapreduce.Job;
 import org.apache.hadoop.mapreduce.MRConfig;
 import org.apache.hadoop.mapreduce.MRJobConfig;
+import org.apache.hadoop.util.functional.CallableRaisingIOE;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
 
+/**
+ * Test the LocalDistributedCacheManager using mocking.
+ * This suite is brittle to changes in the class under test.
+ */
 @SuppressWarnings("deprecation")
 public class TestLocalDistributedCacheManager {
 
+  public static final byte[] TEST_DATA = "This is a test file\n".getBytes();

Review Comment:
   sorry, IDE did that without me noticing





Issue Time Tracking
-------------------

    Worklog Id:     (was: 783787)
    Time Spent: 1h 10m  (was: 1h)

> TestLocalDistributedCacheManager failing after HADOOP-16202
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-7391
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7391
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.4.0, 3.3.9
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> After HADOOP-16202, TestLocalDistributedCacheManager.testDownload is failing 
> with an NPE



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to