[
https://issues.apache.org/jira/browse/MAPREDUCE-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625991#comment-17625991
]
ASF GitHub Bot commented on MAPREDUCE-7425:
-------------------------------------------
cnauroth commented on code in PR #5090:
URL: https://github.com/apache/hadoop/pull/5090#discussion_r1008632148
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml:
##########
@@ -1660,14 +1660,18 @@
<name>yarn.app.mapreduce.client-am.ipc.max-retries</name>
<value>3</value>
<description>The number of client retries to the AM - before reconnecting
- to the RM to fetch Application Status.</description>
+ to the RM to fetch Application Status.
+ In other words, it is the ipc.client.connect.max.retries to be used during
+ reconnecting to the RM and fetching Application Status.</description>
Review Comment:
I think it's a good update, because it makes it clear that
`ipc.client.connect.max.retries` (the common property for controlling this in
Hadoop's RPC framework) is not actually in effect for this code path, and
instead there is another property, with a different default, taking the place
of `ipc.client.connect.max.retries`.
This also brings this property's documentation into alignment with other
similar properties, such as these from yarn-default.xml:
```
<property>
<description>When HA is enabled, the number of retries per
attempt to connect to a ResourceManager. In other words,
it is the ipc.client.connect.max.retries to be used during
failover attempts</description>
<name>yarn.client.failover-retries</name>
<value>0</value>
</property>
```
```
<property>
<description>When HA is enabled, the number of retries per
attempt to connect to a ResourceManager on socket timeouts. In other
words, it is the ipc.client.connect.max.retries.on.timeouts to be used
during failover attempts</description>
<name>yarn.client.failover-retries-on-socket-timeouts</name>
<value>0</value>
</property>
```
> Document Fix for yarn.app.mapreduce.client-am.ipc.max-retries
> -------------------------------------------------------------
>
> Key: MAPREDUCE-7425
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7425
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: yarn
> Affects Versions: 3.3.4
> Reporter: teng wang
> Priority: Major
> Labels: pull-request-available
>
> The document of *yarn.app.mapreduce.client-am.ipc.max-retries* and
> *yarn.app.mapreduce.client-am.ipc.max-retries-on-timeouts* is not detailed
> and complete. *yarn.app.mapreduce.client-am.ipc.max-retries* is used to
> *overwrite ipc.client.connect.max.retries* in ClientServiceDelegate.java. So,
> the document is suggested to fix as: (refer to yarn.client.failover-retries)
>
> {code:java}
> // mapred-default.xml
> <property>
> <name>yarn.app.mapreduce.client-am.ipc.max-retries</name>
> <value>3</value>
> <description>The number of client retries to the AM - before reconnecting
> - to the RM to fetch Application Status.</description>
> + to the RM to fetch Application Status.
> + In other words, it is the ipc.client.connect.max.retries to be used
> during
> + reconnecting to the RM and fetching Application Status.</description>
> </property> {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
