[
https://issues.apache.org/jira/browse/MAPREDUCE-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765993#comment-17765993
]
ASF GitHub Bot commented on MAPREDUCE-7455:
-------------------------------------------
teamconfx opened a new pull request, #6093:
URL: https://github.com/apache/hadoop/pull/6093
### Description of PR
A large `mapreduce.job.reduces` can cause overflow while computing the byte
buffer in `org.apache.hadoop.mapred.SpillRecord#SpillRecord(int)`, since the
byte buffer size equals to `mapreduce.job.reduces` *
MapTask.MAP_OUTPUT_INDEX_RECORD_LENGTH
To reproduce:
1. set `mapreduce.job.reduces` to 509103844
2. run `mvn surefire:test
-Dtest=org.apache.hadoop.mapred.TestMapTask#testShufflePermissions`
This PR provides a fix by checking the computed buffer size is positive.
### How was this patch tested?
Unit test
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under ASF 2.0?
- [ ] If applicable, have you updated the LICENSE, LICENSE-binary,
NOTICE-binary files?
> org.apache.hadoop.mapred.SpillRecord crashes due to overflow in buffer size
> computation
> ---------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.3.6
> Reporter: ConfX
> Priority: Major
> Labels: pull-request-available
>
> A large `mapreduce.job.reduces` can cause overflow while computing the byte
> buffer in `org.apache.hadoop.mapred.SpillRecord#SpillRecord(int)`, since the
> byte buffer size equals to `mapreduce.job.reduces` *
> MapTask.MAP_OUTPUT_INDEX_RECORD_LENGTH
> To reproduce:
> 1. set `mapreduce.job.reduces` to 509103844
> 2. run `mvn surefire:test
> -Dtest=org.apache.hadoop.mapred.TestMapTask#testShufflePermissions`
> We create a PR that provides a fix by checking the computed buffer size is
> positive.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
