[ https://issues.apache.org/jira/browse/MAPREDUCE-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840307#comment-17840307 ]
ASF GitHub Bot commented on MAPREDUCE-7474: ------------------------------------------- hadoop-yetus commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2074254789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 05s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 05s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 05s | | detect-secrets was not available. | | +0 :ok: | shellcheck | 0m 05s | | Shellcheck was not available. | | +0 :ok: | shelldocs | 0m 05s | | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 01s | | spotbugs executables are not available. | | +0 :ok: | markdownlint | 0m 01s | | markdownlint was not available. | | +0 :ok: | xmllint | 0m 01s | | xmllint was not available. | | +1 :green_heart: | @author | 0m 00s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 00s | | The patch appears to include 10 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 2m 13s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 89m 13s | | trunk passed | | +1 :green_heart: | compile | 39m 10s | | trunk passed | | +1 :green_heart: | checkstyle | 6m 15s | | trunk passed | | +1 :green_heart: | mvnsite | 16m 30s | | trunk passed | | +1 :green_heart: | javadoc | 14m 00s | | trunk passed | | +1 :green_heart: | shadedclient | 170m 25s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 2m 13s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 11m 14s | | the patch passed | | +1 :green_heart: | compile | 37m 21s | | the patch passed | | +1 :green_heart: | javac | 37m 21s | | the patch passed | | +1 :green_heart: | blanks | 0m 01s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 5m 47s | | the patch passed | | +1 :green_heart: | mvnsite | 16m 05s | | the patch passed | | +1 :green_heart: | javadoc | 13m 42s | | the patch passed | | +1 :green_heart: | shadedclient | 178m 33s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 29s | | The patch does not generate ASF License warnings. | | | | 543m 45s | | | | Subsystem | Report/Notes | |----------:|:-------------| | GITHUB PR | https://github.com/apache/hadoop/pull/6716 | | Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint xmllint | | uname | MINGW64_NT-10.0-17763 b033f3aa81e5 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys | | Build tool | maven | | Personality | /c/hadoop/dev-support/bin/hadoop.sh | | git revision | trunk / 2b38434c46b494f7689acc125a52935d6cb17870 | | Default Java | Azul Systems, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6716/1/testReport/ | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project hadoop-tools/hadoop-azure U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6716/1/console | | versions | git=2.44.0.windows.1 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > [ABFS] Improve commit resilience and performance in Manifest Committer > ---------------------------------------------------------------------- > > Key: MAPREDUCE-7474 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7474 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client > Affects Versions: 3.4.0, 3.3.6 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Major > Labels: pull-request-available > > * Manifest committer is not resilient to rename failures on task commit > without HADOOP-18012 rename recovery enabled. > * large burst of delete calls noted: are they needed? > relates to HADOOP-19093 but takes a more minimal approach with goal of > changes in manifest committer only. > Initial proposed changes > * retry recovery on task commit rename, always (repeat save, delete, rename) > * audit delete use and see if it can be pruned -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org