[ https://issues.apache.org/jira/browse/MAPREDUCE-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844693#comment-17844693 ]
ASF GitHub Bot commented on MAPREDUCE-7475: ------------------------------------------- hadoop-yetus commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2100800444 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 01s | | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 01s | | spotbugs executables are not available. | | +0 :ok: | codespell | 0m 01s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 01s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 00s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 01s | | The patch appears to include 6 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 2m 59s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 109m 16s | | trunk passed | | +1 :green_heart: | compile | 8m 00s | | trunk passed | | +1 :green_heart: | checkstyle | 5m 43s | | trunk passed | | +1 :green_heart: | mvnsite | 17m 55s | | trunk passed | | +1 :green_heart: | javadoc | 16m 52s | | trunk passed | | +1 :green_heart: | shadedclient | 205m 05s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 3m 04s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 35s | | the patch passed | | +1 :green_heart: | compile | 4m 50s | | the patch passed | | +1 :green_heart: | javac | 4m 50s | | the patch passed | | -1 :x: | blanks | 0m 00s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6785/1/artifact/out/blanks-eol.txt) | The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | checkstyle | 2m 57s | | the patch passed | | +1 :green_heart: | mvnsite | 9m 30s | | the patch passed | | +1 :green_heart: | javadoc | 8m 00s | | the patch passed | | +1 :green_heart: | shadedclient | 204m 26s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | asflicense | 6m 30s | | The patch does not generate ASF License warnings. | | | | 563m 16s | | | | Subsystem | Report/Notes | |----------:|:-------------| | GITHUB PR | https://github.com/apache/hadoop/pull/6785 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | MINGW64_NT-10.0-17763 1ac01a056e3d 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys | | Build tool | maven | | Personality | /c/hadoop/dev-support/bin/hadoop.sh | | git revision | trunk / 6e7c3ec42a278683c5d0b34242e1889ca8a67612 | | Default Java | Azul Systems, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6785/1/testReport/ | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6785/1/console | | versions | git=2.44.0.windows.1 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > 2 tests are non-idempotent (passes in the first run but fails in repeated > runs in the same JVM) > ----------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-7475 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7475 > Project: Hadoop Map/Reduce > Issue Type: Bug > Environment: Ubuntu 22.04, Java 17 > Reporter: Kaiyao Ke > Priority: Major > Labels: pull-request-available > Original Estimate: 10m > Remaining Estimate: 10m > > 2 tests are not idempotent and fails upon repeated execution within the same > JVM instance due to self-induced state pollution. Specifically, these tests > try to make the directory TEST_ROOT_DIR and write to it. The tests do not > clean up (remove) the directory after execution. Therefore, in the second > execution, TEST_ROOT_DIR would already exist and the exception `Could not > create test dir` would be thrown. Below are the 2 non-idempotent tests: > * org.apache.hadoop.mapred.TestOldCombinerGrouping.testCombiner > * org.apache.hadoop.mapreduce.TestNewCombinerGrouping.testCombiner -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org