[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845205#comment-17845205
 ] 

ASF GitHub Bot commented on MAPREDUCE-7402:
-------------------------------------------

hadoop-yetus commented on PR #6622:
URL: https://github.com/apache/hadoop/pull/6622#issuecomment-2103907810

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m 00s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  spotbugs  |   0m 01s |  |  spotbugs executables are not 
available.  |
   | +0 :ok: |  codespell  |   0m 01s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m 01s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m 00s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m 00s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  92m 25s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   5m 10s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   5m 00s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   5m 14s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m 41s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  | 147m 57s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 35s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 35s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m 00s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   2m 05s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 34s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 05s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  | 158m 58s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |  12m 00s | 
[/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6622/4/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt)
 |  hadoop-mapreduce-client-core in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   5m 39s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 442m 08s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.mapred.TestTaskProgressReporter |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | GITHUB PR | https://github.com/apache/hadoop/pull/6622 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | MINGW64_NT-10.0-17763 759ee4f0c44d 3.4.10-87d57229.x86_64 
2024-02-14 20:17 UTC x86_64 Msys |
   | Build tool | maven |
   | Personality | /c/hadoop/dev-support/bin/hadoop.sh |
   | git revision | trunk / dff82fdd3ca73a2fd2b8b9c33330a97f50135f26 |
   | Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6622/4/testReport/
 |
   | modules | C: 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
U: 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6622/4/console
 |
   | versions | git=2.44.0.windows.1 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> fix mapreduce.task.io.sort.factor=1 lead to an infinite loop.
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-7402
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7402
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Jian Zhang
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: screenshot-1.png
>
>
> *Describe:*
>     In the method long computeBytesInMerges(int factor, int inMem), when 
> factor is set to 1, and the initial numSegments>1, inMem=0, it will cause an 
> infinite loop of while. Although setting factor to 1 is meaningless, and it 
> will not be done in actual production, we need to remind users to avoid an 
> infinite loop due to carelessness.
>  !screenshot-1.png|width=600,height=400!
> *How to reproduce:*
>     This bug can easily occur by setting 
> configuration.set("mapreduce.task.io.sort.factor", "1").



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to