[ https://issues.apache.org/jira/browse/MAPREDUCE-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924319#comment-17924319 ]
ASF GitHub Bot commented on MAPREDUCE-7418: ------------------------------------------- cnauroth commented on code in PR #7350: URL: https://github.com/apache/hadoop/pull/7350#discussion_r1943870640 ########## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ########## @@ -257,12 +260,6 @@ public void testGetMapCompletionEvents() throws IOException { createTce(3, false, TaskAttemptCompletionEventStatus.FAILED) }; TaskAttemptCompletionEvent[] mapEvents = { taskEvents[0], taskEvents[2] }; Job mockJob = mock(Job.class); - when(mockJob.getTaskAttemptCompletionEvents(0, 100)) Review Comment: Is this code removed intentionally? ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java: ########## @@ -369,9 +369,15 @@ public void setup() { if (httpScheme.equals(WebAppUtils.HTTPS_PREFIX)) { String amKeystoreLoc = System.getenv("KEYSTORE_FILE_LOCATION"); + if (StringUtils.isBlank(amKeystoreLoc)) { Review Comment: Understood, thank you! > Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app > --------------------------------------------------- > > Key: MAPREDUCE-7418 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7418 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: test > Affects Versions: 3.3.4 > Reporter: Ashutosh Gupta > Assignee: Ashutosh Gupta > Priority: Major > Labels: pull-request-available > > Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org