[
https://issues.apache.org/jira/browse/MAPREDUCE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925135#comment-17925135
]
ASF GitHub Bot commented on MAPREDUCE-7420:
-------------------------------------------
cnauroth commented on code in PR #7363:
URL: https://github.com/apache/hadoop/pull/7363#discussion_r1947474810
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/TestPathOutputCommitterFactory.java:
##########
@@ -156,9 +156,9 @@ public void testNamedCommitterFactory() throws Throwable {
SimpleCommitter sc = createCommitter(
NamedCommitterFactory.class,
SimpleCommitter.class, HDFS_PATH, conf);
- assertEquals("Wrong output path from " + sc,
- HDFS_PATH,
- sc.getOutputPath());
+ assertEquals(
+ HDFS_PATH
+, sc.getOutputPath(), "Wrong output path from " + sc);
Review Comment:
Odd formatting here?
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##########
@@ -250,6 +250,20 @@ protected Path methodPath() throws IOException {
return path(methodName.getMethodName());
}
+ /**
+ * Get a path whose name ends with the name of this method.
+ *
+ * This is a temporary requirement for upgrading from JUnit 4 to JUnit 5,
+ * and can be deleted later.
+ *
+ * @param name name of this method.
+ * @return a path implicitly unique amongst all methods in this class
+ * @throws IOException IO problems
+ */
+ protected Path methodPath(String name) throws IOException {
Review Comment:
I'm unclear, is anything actually calling this method?
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core
> ----------------------------------------------------
>
> Key: MAPREDUCE-7420
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7420
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: test
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
