[
https://issues.apache.org/jira/browse/MAPREDUCE-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18045078#comment-18045078
]
ASF GitHub Bot commented on MAPREDUCE-7524:
-------------------------------------------
18chanp1 opened a new pull request, #8134:
URL: https://github.com/apache/hadoop/pull/8134
…by removing assertions based on the internal implementation of HDFS.
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
`org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacementForCompressedFiles`
makes a number of assertions that are not guaranteed by internal
implementation.
For example, the test makes assumptions on the order in which racks are
processed. Splits in the HDFS can appear in a different order depending on the
internal state / implementation / metadata which is not guaranteed by the
interface.
For example, there are assertions such as split.equals(splits.get(0)), which
assumes a specific ordering of InputSplit objects that may vary depending on
internal implementation.
This can be addressed by eliminating assertions based on the internal
implementation / ways that the racks are split.
### How was this patch tested?
existing tests that pass continue to pass and tests that fail continue to
fail. The tests were inspected closely to ensure that the original assertions
were followed while maintaining deterministic ordering
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [X] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> testSplitPlacementForCompressedFiles is non-deterministic from time to time
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-7524
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7524
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Paco Chan
> Priority: Trivial
>
> {code:java}
> org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacementForCompressedFiles{code}
> makes a number of assertions that are not guaranteed by internal
> implementation.
>
> For example, the test makes assumptions on the order in which racks are
> processed. Splits in the HDFS can appear in a different order depending on
> the internal state / implementation / metadata which is not guaranteed by the
> interface.
>
> For example, there are assertions such as split.equals(splits.get(0)), which
> assumes a specific ordering of InputSplit objects that may vary depending on
> internal implementation.
>
> This can be addressed by eliminating assertions based on the internal
> implementation / ways that the racks are split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
