[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073964#comment-18073964
 ] 

ASF GitHub Bot commented on MAPREDUCE-6706:
-------------------------------------------

steveloughran commented on code in PR #8422:
URL: https://github.com/apache/hadoop/pull/8422#discussion_r3092984134


##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/security/TestUmbilicalProtocolWithJobToken.java:
##########
@@ -51,10 +55,11 @@
 import org.junit.jupiter.api.Test;
 import static org.slf4j.LoggerFactory.getLogger;
 
-/** Unit tests for using Job Token over RPC. 
- * 
+/** Unit tests for using Job Token over RPC.
+ *
  * System properties required:
- * 
-Djava.security.krb5.conf=.../hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/target/test-classes/krb5.conf
 
+ * -Djava.security.krb5.conf=.../hadoop-mapreduce-client/
+ *   hadoop-mapreduce-client-jobclient/target/test-classes/krb5.conf

Review Comment:
   looks like an error. will fix





> Update TaskUmbilicalProtocol to use ProtobufRPCEngine
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-6706
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6706
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Arun Suresh
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, {{TaskUmbilicalProtocol}} still uses {{WritableRPCEngine}}, which 
> should be moved to {{ProtocolRPCEngine}} so that the former can be deprecated 
> as tracked by HADOOP-12579



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to