[
https://issues.apache.org/jira/browse/MAPREDUCE-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101209#comment-18101209
]
ASF GitHub Bot commented on MAPREDUCE-7541:
-------------------------------------------
Copilot commented on code in PR #8652:
URL: https://github.com/apache/hadoop/pull/8652#discussion_r3701582085
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AMWebApp.java:
##########
@@ -38,6 +40,7 @@ public AMWebApp(AppContext appContext) {
@Override
public void setup() {
+ bind(App.class).in(Singleton.class);
bind(AppContext.class).toInstance(appContext);
Review Comment:
Binding App as a Guice Singleton is unsafe here because App holds mutable
per-request state (job/task via setJob/setTask). With a Singleton, concurrent
requests can overwrite each other’s job/task and leak state across
users/requests; the Attempts page needs a single shared App *per request*, not
globally. Use Guice’s `@RequestScoped` instead (WebApp is a ServletModule so
request scope is available).
> Fix AM WebUI attempts page
> --------------------------
>
> Key: MAPREDUCE-7541
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7541
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.5.0, 3.6.0
> Reporter: D M Murali Krishna Reddy
> Assignee: D M Murali Krishna Reddy
> Priority: Major
> Labels: pull-request-available
> Attachments: Screenshot from 2026-08-02 18-13-04.png
>
>
> For a IN PROGRESS Mapreduce application navigating to AM UI at
> /proxy/<app_id>/mapreduce/attempts/<job_id>/m/SUCCESSFUL is not displaying
> the successful attemps.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
