The debug levels are 0 to 5, 0 being none, and 5 being the most verbose.
I believe the problem in msDrawRasterLayerLow() is that it uses a "=="
test instead of a ">=".
i.e. it uses:
if(layer->debug == MS_TRUE)
but it should use
if(layer->debug >= 1)
or even better use the debugLevel constants from maperror.h in the test
condition:
typedef enum { MS_DEBUGLEVEL_ERRORSONLY = 0, /* DEBUG OFF, log fatal
errors */
MS_DEBUGLEVEL_DEBUG = 1, /* DEBUG ON */
MS_DEBUGLEVEL_TUNING = 2, /* Reports timing info */
MS_DEBUGLEVEL_V = 3, /* Verbose */
MS_DEBUGLEVEL_VV = 4, /* Very verbose */
MS_DEBUGLEVEL_VVV = 5 /* Very very verbose */
} debugLevel;
i.e.
if(layer->debug >= MS_DEBUGLEVEL_DEBUG)
Daniel
On 2018-11-16 11:26 a.m., Lime, Steve D (MNIT) wrote:
This isn’t surprising. We haven’t been real good about consistently
using levels across the code base – cleaning that up would be a good
project (or sprint activity) and wouldn’t require deep technical knowledge.
I’ll create a ticket for the case you’ve pointed about below…
--Steve
*From:* mapserver-users [mailto:mapserver-users-boun...@lists.osgeo.org]
*On Behalf Of *Rahkonen Jukka (MML)
*Sent:* Friday, November 16, 2018 5:48 AM
*To:* Mapserver-Users (mapserver-users@lists.osgeo.org)
<mapserver-users@lists.osgeo.org>
*Subject:* [mapserver-users] About the granularity of DEBUG on tileindex
layers
Hi,
I have always used just ”DEBUG 5” for debugging raster layers but now I
finally made a test with Mapserver 7.0.1 for seeing what is the real
difference between the debugging levels. I was a bit surprised to see
that there is not so much difference at all, and that the DEBUG 1 level
gives information that is missing from the higher debugging levels but
that would be useful sometimes.
Debug 1 prints these lines
[Fri Nov 16 12:05:50 2018].964589 msDrawRasterLayerLow(layer_name):
entering.
[Fri Nov 16 12:05:50 2018].980393 msDrawRasterLayerLow(layer_name):
Filename is: path/file.TIF
[Fri Nov 16 12:05:50 2018].980423 msDrawRasterLayerLow(layer_name): Path
is: path/file.TIF
[Fri Nov 16 12:05:50 2018].980591 AUTO = +proj=utm +zone=35 +ellps=GRS80
+towgs84=0,0,0,0,0,0,0 +units=m +no_defs
[Fri Nov 16 12:05:50 2018].980677 msDrawRasterLayerGDAL(): Entering
transform.
[Fri Nov 16 12:05:50 2018].980687 msDrawRasterLayerGDAL():
src=9979,8,1786,1062, dst=0,0,1697,1009
[Fri Nov 16 12:05:50 2018].980691 msDrawRasterLayerGDAL(): source raster
PL (9978.817,7.700) for dst PL (0,0).
[Fri Nov 16 12:05:50 2018].980700 msDrawRasterLayerGDAL():
red,green,blue,alpha bands = 1,2,3,0
All debug levels from level 2 print these lines:
[Fri Nov 16 12:09:05 2018].581597 msDrawRasterLayerLow(layer_name):
entering.
[Fri Nov 16 12:09:05 2018].589989 AUTO = +proj=utm +zone=35 +ellps=GRS80
+towgs84=0,0,0,0,0,0,0 +units=m +no_defs
[Fri Nov 16 12:09:05 2018].590061 msDrawRasterLayerGDAL(): Entering
transform.
[Fri Nov 16 12:09:05 2018].590069 msDrawRasterLayerGDAL():
src=2318,7977,1786,1062, dst=0,0,1697,1009
[Fri Nov 16 12:09:05 2018].590073 msDrawRasterLayerGDAL(): source raster
PL (2317.846,7977.061) for dst PL (0,0).
[Fri Nov 16 12:09:05 2018].590081 msDrawRasterLayerGDAL():
red,green,blue,alpha bands = 1,2,3,0
[Fri Nov 16 12:09:05 2018].720794 msDrawMap(): Layer 3 (layer_name), 0.139s
The only additional item that debug levels 2 and above give is the
rendering time msDrawMap that is often useful. But at the same time the
filename and path items which are present at debug level 1 are missing.
I suggest to add debug items msDrawRasterLayerLow(): Filename and
msDrawRasterLayerLow(): Path should be added alto to debug levels >=2.
For being even more useful the highest debug level could give also
timings about reading the tileindex and perhaps separate timings about
things like how long does it take to read the “src” window from each
“Filename” and if overviews are used or not.
-Jukka Rahkonen-
_______________________________________________
mapserver-users mailing list
mapserver-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users
--
Daniel Morissette
Mapgears Inc
T: +1 418-696-5056 #201
_______________________________________________
mapserver-users mailing list
mapserver-users@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-users
