> On aug. 24, 2014, 9:24 du, Dennis Nienhüser wrote: > > Hi Gábor, hi Torsten, > > > > this looks like a great feature, thanks for your work on it. The patch > > however is growing **huge** and I see no possibility for a sane review. At > > the same time I spot several architectural issues that must be addressed as > > soon as possible. Can we have an IRC meeting or similar to discuss this? > > > > Regards, > > Dennis
Hi Dennis, Tomorrow (Monday) I will be available all day on irc, so I hope we can manage this tomorrow. Another: Maybe the patch becoming this huge because the dependency patches are in this patch too. Maybe I missed something and this can be prevented somehow... Thanks for trying to review, Regards, Gábor - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119903/#review65146 ----------------------------------------------------------- On aug. 23, 2014, 11:09 du, Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119903/ > ----------------------------------------------------------- > > (Updated aug. 23, 2014, 11:09 du) > > > Review request for Marble and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > This patch contains the code for creating map theme from GeoDataPhotoOverlay, > visualising with a MarbleWidget and managing temporary files for the proccess. > > > Diffs > ----- > > src/lib/marble/MarbleMap.cpp 25007ac7921df3ca447eb587e9d12ffc838e6856 > src/lib/marble/MarbleModel.h 9643186b62429a4e04f421030d64b8ab86cd7f7c > src/lib/marble/MarbleModel.cpp 3bd408c76f29ef8e39430b9d8e1645cf0b17f95f > src/lib/marble/MarbleWidget.h dfc1aa7bc8004e96a7759d06165580bf8c56b63c > src/lib/marble/MarbleWidget.cpp d4c7ff48145bd55de23cf0a0e4a2b92e8037bb29 > src/lib/marble/MarbleWidgetPopupMenu.cpp > 1dc7760903f4899e830d754957651c6681172971 > src/lib/marble/PopupItem.h 4c65004d1386305c3394f5b343bc67cff9127f39 > src/lib/marble/PopupItem.cpp a4e973ad60a2a8dd24fc5370b6eaf95b247f5bb5 > src/lib/marble/RenderPlugin.h 67472fa005f191c823f188848926f87150ba9c98 > src/lib/marble/RenderPlugin.cpp 1f2e9b1f679914a96337042fd6d9b347dac2533e > src/lib/marble/ViewportParams.cpp d6cf03603b353671f52440adcea15ddecf188b94 > src/lib/marble/WebPopupWidget.ui 8cf7103185281833924b0e36da655b2fbe19b8b6 > src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp > 456886b28df1df424dcc5c8577ccad6b38174bd0 > src/lib/marble/geodata/data/GeoDataPlacemark.h > 96028e426a9688ffbb48cf8942eba2455a06b581 > src/lib/marble/geodata/data/GeoDataPlacemark.cpp > b2d0304ec10e2243538cf1cdb252c2da7f0cde5c > src/lib/marble/geodata/data/GeoDataPlacemark_p.h > b4c1ee1a7f53d596baada68c94bba72cb26a9e53 > src/lib/marble/geodata/graphicsitem/GeoPhotoGraphicsItem.cpp > 4fab8fb25528706527e9138d10a4850c20025437 > src/lib/marble/layers/GeometryLayer.h > 8d86aed059f7d6e36fd668bedb1f26d467cd2887 > src/lib/marble/MapViewWidget.cpp b55dc1cfbf5caa7d44846bedaf048648009a6076 > src/lib/marble/MarbleGlobal.h 69a96f3badc69edc36a0163a173f7214fe71aeb5 > src/lib/marble/MapViewWidget.h 9a86c1e5d06df2a1ed44eab8f10544cf3b8acc7e > src/lib/marble/MapThemeManager.h d18c8de6ec29153e00d079a4b30579ca1d9be14d > src/lib/marble/MapThemeManager.cpp 725cc44614073b2ee114a448ce08254ceffa4f5d > src/lib/marble/LayerManager.h 858fcdaf93810ce3f3b159aacc463c79725b06e6 > src/lib/marble/LayerManager.cpp 436473162b5d473038f33a1eb75afb5844f86a91 > src/lib/marble/GnomonicScanlineTextureMapper.cpp PRE-CREATION > src/lib/marble/FileStoragePolicy.cpp > 559495423fd5b8ad6450234a89902f0f1896cd8c > src/lib/marble/GnomonicScanlineTextureMapper.h PRE-CREATION > data/bitmaps/webpopup/icon-panorama.png PRE-CREATION > src/apps/marble-qt/QtMainWindow.cpp > d7beaff0a4758ab7bc752289549e88a6d173359a > src/apps/marble-ui/ControlView.h 5cb75a59880b5b25f12fd12bc6fc0976fb06efa4 > src/apps/marble-ui/ControlView.cpp fdc66d5b735a9f526582176b29471f0ea673066c > src/lib/marble/CMakeLists.txt 532ec3d3e63bd78e06600f0c11a2ee653f56a721 > src/lib/marble/FileStoragePolicy.h aaff71a2c3e40e618d5370d463e4a9edab55011f > src/lib/marble/projections/AzimuthalProjection_p.h PRE-CREATION > src/lib/marble/projections/AzimuthalProjection.cpp PRE-CREATION > src/lib/marble/projections/AzimuthalProjection.h PRE-CREATION > src/lib/marble/layers/TextureLayer.cpp > 845b032c7b7603af5af0bdb9064b01e0a0817af3 > src/lib/marble/libmarble.qrc ea7c956750700d4b7db01974ea79d8a9362afc06 > src/lib/marble/layers/GeometryLayer.cpp > fbfe9a379ef6308d065d00b9b75188e8b33f1054 > src/lib/marble/layers/PopupLayer.h 8f9fcc66c8a6def5249757d7f17c22427aa87699 > src/lib/marble/layers/PopupLayer.cpp > b7abd977eb140add867b7b347242d636e8c1c757 > src/lib/marble/webpopup/photooverlay.html PRE-CREATION > src/lib/marble/projections/SphericalProjection.cpp > 669851ee72d89a128814de8e7575d6db4ce5db15 > src/plugins/render/speedometer/Speedometer.h > 7ecbc57f064beca11d34003ee22703f9b5485f78 > src/plugins/render/speedometer/Speedometer.cpp > f374d9d5a7a58e886917f9d27c2d85ec1b57798c > src/plugins/render/stars/StarsPlugin.h > 341e3f01835029c4976379c29c1a4ab05444d64c > src/plugins/render/stars/StarsPlugin.cpp > cf59abfec13c491cec108f024bda6a94eeae0275 > src/plugins/render/sun/SunPlugin.h a47d2a427de6b6750ce43dd39aeddba463eecdcb > src/plugins/render/sun/SunPlugin.cpp > b03fac2c195ad0e532132ef0c20e7385f9ce522a > src/plugins/render/weather/WeatherPlugin.h > 3020d3ff461641095e274cfeb35cba648904c9e7 > src/plugins/render/weather/WeatherPlugin.cpp > 2d3b6194a1d9d09807ce30a2c0b13e2842e146bb > src/plugins/render/wikipedia/WikipediaPlugin.h > 71471b7d666bc6cd9c6fc0948b976e8d14baf929 > src/plugins/render/wikipedia/WikipediaPlugin.cpp > 2777f7bc2bb72dfa85f6deeff1b86f0ecf720b9b > src/plugins/render/progress/ProgressFloatItem.h > 31d491dffdb264c51d043a2cf45ff8b74872a701 > src/plugins/render/progress/ProgressFloatItem.cpp > 314c7b835995859f5bb053c284af734bea4a2f8b > src/plugins/render/routing/RoutingPlugin.h > 72537e181406486af283e6bbb58b79ca7c690a94 > src/plugins/render/routing/RoutingPlugin.cpp > 3881c9ece7ff500d1ef383bb37ef0c5f7cac2f55 > src/plugins/render/satellites/SatellitesPlugin.h > 7b822e563187326066003a625e9f34ddc6a633ee > src/plugins/render/satellites/SatellitesPlugin.cpp > d5c8a647fb15266daae11914b1c4e099a0cc245b > src/plugins/declarative/MarbleDeclarativeWidget.cpp > 0cb6c94d584f385317caa8e88f19fbfec57a5a95 > src/plugins/render/annotate/AnnotatePlugin.h > 8d459e8eade88b337a3207f1a496606bd104647e > src/plugins/render/annotate/AnnotatePlugin.cpp > e62816725c884b8b0a8ae18ee4c4862be909041a > src/plugins/render/aprs/AprsPlugin.h > 4a2758a5e25906250c019e0125b3b5efe5fe1203 > src/plugins/render/aprs/AprsPlugin.cpp > 2485a30b115571f1ea0ff6b885cb8710b4ee53cd > src/plugins/render/atmosphere/AtmospherePlugin.h > 2294398a6dfda67a82d008480d02d86f19ea7609 > src/plugins/render/atmosphere/AtmospherePlugin.cpp > 492c1113221810989ed28d7c73a19d18363db2ea > src/plugins/render/compass/CompassFloatItem.h > ae155dfa8387afbc2be6af6ee20d4784f1440727 > src/plugins/render/compass/CompassFloatItem.cpp > a674f51695b0f7345d546336fbd1ebb98b02ae7d > src/plugins/render/crosshairs/CrosshairsPlugin.h > 543f1c393fb03da64dba9b28d0270eee95582cca > src/plugins/render/crosshairs/CrosshairsPlugin.cpp > c6274291ae1acb9583ac10342de0cd332dd1fc9d > src/plugins/render/earthquake/EarthquakePlugin.h > 1cb88b710798d31eb29ecb21b9c9744830a5e8a6 > src/plugins/render/earthquake/EarthquakePlugin.cpp > 47f041c8e3f40d19d151ff219b6f7ed9e2506ad1 > src/plugins/render/eclipses/EclipsesPlugin.h > 8756d4652680d66f895bee0e9803c088538a2779 > src/plugins/render/eclipses/EclipsesPlugin.cpp > 459c870e6edc18df552f7e712df4978ac08ae547 > src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h > db66ae1f829c88be1d5908cd442dca9e88962853 > src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp > db4113cda16733e709a820f1aa2ddc1681219c80 > src/plugins/render/elevationprofilemarker/ElevationProfileMarker.h > 39e6847d9b2a2704c7ded36ad76f99e7ace48195 > src/plugins/render/elevationprofilemarker/ElevationProfileMarker.cpp > c453e8c51d5131d887f0c9ec7fae24aa108b28c3 > src/plugins/render/foursquare/FoursquarePlugin.h > 19f3e7d734568f419e7023b754c896debaac875a > src/plugins/render/foursquare/FoursquarePlugin.cpp > dbc4928394ea06435853b1a78545d5d0708425f1 > src/plugins/render/gpsinfo/GpsInfo.h > 76dc01b8f565122812f1f74476a4a080e8f1661f > src/plugins/render/gpsinfo/GpsInfo.cpp > e3d8f492db4a92658b0757f150b0032f1871402a > src/plugins/render/graticule/GraticulePlugin.h > e48cb422cb6ffd89658c0581a3b0b446d5822f5f > src/plugins/render/graticule/GraticulePlugin.cpp > a5e6d14a921c66d55cf01e39b16564dedcf6532b > src/plugins/render/license/License.h > 74be899318a786b5bb352a29a4e61b810290abf6 > src/plugins/render/license/License.cpp > 4470f14bef791ea21d3ce60d0a21848f0981ed13 > src/plugins/render/mapscale/MapScaleFloatItem.h > 4a0f922594ba6a23bff69f038e26c8baaa3f6472 > src/plugins/render/mapscale/MapScaleFloatItem.cpp > ea869bbe0b946e33eacc0cb7246c28c315cecc16 > src/plugins/render/measure/MeasureToolPlugin.h > 2c2c27b8ed8ad9b7a959b4dc297c5f55173b362a > src/plugins/render/measure/MeasureToolPlugin.cpp > 689c8b1ca9ad59eacf8d73291479fbd5c20e34db > src/plugins/render/navigation/NavigationFloatItem.h > 14cdcaa7093e695a6cb62572f0cbfca243bc59fa > src/plugins/render/navigation/NavigationFloatItem.cpp > 47b057001e4661e669e5ade78206c55993eede9d > src/plugins/render/opencachingcom/OpenCachingComPlugin.h > 16d75eb6dff8650b21c1cea2927b224c8e04e028 > src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp > 45a92f25f3fa85729bfdd19c199eabb2d49d977a > src/plugins/render/opendesktop/OpenDesktopPlugin.h > 2998c2d451697bd26e70c4f1128cc6a2c2904a8c > src/plugins/render/opendesktop/OpenDesktopPlugin.cpp > f54fd1442fc38da8642f5fb0b7e4e68f8841b978 > src/plugins/render/overviewmap/OverviewMap.h > 4c9ada8ebf411b23ac4df641a3a2c5e28004ac08 > src/plugins/render/overviewmap/OverviewMap.cpp > 1408261ea4b6cc34ff59060a5af37a6c25365e2e > src/plugins/render/photo/PhotoPlugin.h > 63d11eb386233fa7ec6fb8aa480037ef6f7f5fe9 > src/plugins/render/photo/PhotoPlugin.cpp > 4076a18a285944efc5f3ad9075031e54ee7bfac4 > src/plugins/render/positionmarker/PositionMarker.h > cf2459962dfba33005bc7e7ed3b38b0f12c4d116 > src/plugins/render/positionmarker/PositionMarker.cpp > 45f20c54b517b6bafe26d72b6534eb7c9f66b97c > src/plugins/render/postalcode/PostalCodePlugin.h > caa8930e727ce88bf360b195825ece880f619731 > src/plugins/render/postalcode/PostalCodePlugin.cpp > 87feacdd8035289206da30ff2596844e4e9a2c67 > src/lib/marble/projections/GnomonicProjection.h PRE-CREATION > src/lib/marble/projections/GnomonicProjection.cpp PRE-CREATION > src/lib/marble/projections/SphericalProjection.h > 865407da4e67a6bcdc07fb7bb83ab5f4e7ab7a20 > > Diff: https://git.reviewboard.kde.org/r/119903/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel