----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122686/#review76585 -----------------------------------------------------------
I added some comments on the previous issues. You haven't repaired all of them. Please take one more look on this. src/apps/marble-qt/QtMainWindow.h <https://git.reviewboard.kde.org/r/122686/#comment52751> The asterisk should immediately follow type (QAction). void requestAngleUnitUpdate( QAction* action ); - Calin Cruceru On Feb. 25, 2015, 10:41 a.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122686/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 10:41 a.m.) > > > Review request for Marble. > > > Bugs: 344364 > http://bugs.kde.org/show_bug.cgi?id=344364 > > > Repository: marble > > > Description > ------- > > Menu contains degree(dms), degree(decimal) and utm formats, just like the > settings dialog does. > > > Diffs > ----- > > src/apps/marble-qt/QtMainWindow.h 595ffd2 > src/apps/marble-qt/QtMainWindow.cpp c4280c6 > src/lib/marble/QtMarbleConfigDialog.h 1fbee43 > src/lib/marble/QtMarbleConfigDialog.cpp ed5b62c > > Diff: https://git.reviewboard.kde.org/r/122686/diff/ > > > Testing > ------- > > it works on my machine. > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel