----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123837/#review80708 -----------------------------------------------------------
src/plugins/render/annotate/AnnotatePlugin.cpp (line 393) <https://git.reviewboard.kde.org/r/123837/#comment55338> Please replace `placemark->styleUrl().size() != 0` by `!placemark->styleUrl().isEmpty()` Same below. I'm also wondering if calling GeoDataPlacemark::setStyleUrl( "" ) currently has the effect we want it to have. If not we could change the behavior there also. Didn't really look into it though, just wondered. - Dennis Nienhüser On May 18, 2015, 3:19 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123837/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 3:19 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > When loading OSM files, features are assigned a hardcoded style ( > corresponding to a tag ). That style was overwritten in the annotate plugin's > loadAnnotationFile function. > > > Diffs > ----- > > src/plugins/render/annotate/AnnotatePlugin.cpp 41a6dd9 > > Diff: https://git.reviewboard.kde.org/r/123837/diff/ > > > Testing > ------- > > tested with the following file: http://textuploader.com/fwft > -before the patch, the polygon is white (overwritten to default). > -after the patch, the polygon is blue ( relation's water tag ). > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel