----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123866/#review80741 -----------------------------------------------------------
src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp (line 39) <https://git.reviewboard.kde.org/r/123866/#comment55356> Handling color defaults in KmlColorStyleTagWriter may not be working right because each style tag can have a different default. Even if isEmpty() is never called for any LabelStyleTag, they are all written to .kml. As I see things, this can be solved, either by checking in KmlColorStyleTagWriter for each "nodeType" defaults, or by handling color in each StyleTagWriter. Could you please advise further implementation ? **Unit Test ** ListStyleTest1.kml (FAIL) <- the file doesn't have any <LabelStyle> tags, but <LabelStyle> tags are written to .kml after loading. - Constantin Mihalache On May 22, 2015, 5:24 p.m., Constantin Mihalache wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123866/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 5:24 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Implemented the KmlLabelTagWriter which is useful for writing styles for > TextAnnotations. > > > Diffs > ----- > > src/lib/marble/geodata/CMakeLists.txt fe22e24 > src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.h PRE-CREATION > src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123866/diff/ > > > Testing > ------- > > It works as expected. > > > Thanks, > > Constantin Mihalache > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel