----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/ -----------------------------------------------------------
(Updated July 24, 2015, 1:07 p.m.) Review request for Marble and Gábor Péterffy. Repository: marble Description ------- Move Marble Maps to QQmlApplicationEngine and QtQuick components. Add basic menubar and toolbar. Use "Holo Dark" Android theme. Diffs (updated) ----- src/apps/marble_maps/CMakeLists.txt a259af7 src/apps/marble_maps/MainScreen.qml 96238c5 src/apps/marble_maps/QmlView.h b312d9a src/apps/marble_maps/QmlView.cpp 6c4fc70 src/apps/marble_maps/main.cpp 473ff44 src/apps/marble_maps/package/AndroidManifest.xml 9125e5d Diff: https://git.reviewboard.kde.org/r/124441/diff/ Testing ------- Works on Nexus 5 & Nexus 9 (both Android 5.1.1). Noticed issues: - After clicking on menu navbar appears (see screenshot) and it doesn't hide. I tried to add simple TextField and after: 1) clicking on it; 2) closing keyboard; navbar hides. So, looks it's something focus-related. Also, do we even need to go to fullscreen (immersive mode)? For example Google Earth and Google Maps doesn't use it. File Attachments ---------------- Holo Dark 2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/8c561590-4e50-47f2-83ab-44b883c4f51c__Holo_Dark_2.png Holo Dark 3.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/63c4a2ff-ea1d-47d9-a004-46cc056d7468__Holo_Dark_3.png Holo Dark non-fullscreen.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/4c96aaa9-b06e-4cdf-9b8a-09ff9f1daae3__Holo_Dark_non-fullscreen.png Holo Dark non-fullscreen 2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/1fe9f00b-434d-49d2-ae4d-4341b64f13c8__Holo_Dark_non-fullscreen_2.png Thanks, Mihail Ivchenko
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
