----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124519/#review83402 -----------------------------------------------------------
Ship it! Looks great, both the code and running it on the device :-) - Dennis Nienhüser On Aug. 3, 2015, 6:23 p.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124519/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 6:23 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch introduces the CircleButton qml type. Based on this there is a > button now which navigates the map at the current position. > > > Diffs > ----- > > data/android/drawable-xxxhdpi/backdrop.png PRE-CREATION > data/android/drawable-xxxhdpi/gps_fixed.png PRE-CREATION > data/android/drawable-xxxhdpi/gps_not_fixed.png PRE-CREATION > data/android/drawable-xxxhdpi/marblelogo.png bf462f7 > src/apps/marble-maps/BoxedText.qml PRE-CREATION > src/apps/marble-maps/CircularButton.qml PRE-CREATION > src/apps/marble-maps/MainScreen.qml a3495c0 > src/apps/marble-maps/MarbleMaps.qrc 2978e72 > src/apps/marble-maps/PositionButton.qml PRE-CREATION > src/lib/marble/declarative/MarbleQuickItem.h a0ec46f > src/lib/marble/declarative/MarbleQuickItem.cpp 28f599c > > src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp > 1a11d67 > > Diff: https://git.reviewboard.kde.org/r/124519/diff/ > > > Testing > ------- > > It seems my distance or angle functions are not working well, the almost > always provide false data after some panning (my position is sometimes start > to change when I am panning on the map, strange thing: the position marker > also starts to go to an other place like it is fixed to the screen, but the > map moves under it sometimes when I am penning and it is not jumping back to > its place.) > > > File Attachments > ---------------- > > gps_not_fixed.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png > gps_fixed.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png > marblelogo.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ebaa4d45-b337-4e42-8a23-a73e2d88ddca__marblelogo.png > backdrop.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dacf5958-7270-40c4-9031-243350a80de8__backdrop.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
