> On Aug. 10, 2015, 8:17 p.m., Dennis Nienhüser wrote: > > Yes, I like the idea of having interactive waypoint items. Design-wise I > > wonder if we get the message across by just using different colors for > > markers. Also the circular popup menu looks stylish, but might be annoying > > to extend/change (think of including the placemark's name, its distance or > > address in there). Code-wise it should be easier not to do the menu in C++, > > but in QML as a child item of the existing waypoint delegate > > (WaypointImage).
Can you explain why would you get through the message with the colors? I think it is much more readable if we see the purpose. - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124666/#review83665 ----------------------------------------------------------- On Aug. 15, 2015, 12:03 p.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124666/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2015, 12:03 p.m.) > > > Review request for Marble, Mihail Ivchenko and Dennis Nienhüser. > > > Repository: marble > > > Description > ------- > > - Working back button > - Reworked navigation setup > > > Diffs > ----- > > data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION > data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION > data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION > src/apps/marble-maps/CircularMenu.qml PRE-CREATION > src/apps/marble-maps/MainScreen.qml cb88a0c > src/apps/marble-maps/MarbleMaps.qrc 1cba58d > src/apps/marble-maps/NavigationSetup.qml e552efe > src/apps/marble-maps/ProfileSelectorMenu.qml fc80991 > src/apps/marble-maps/RoutePlanViewer.qml 4ca794e > src/apps/marble-maps/RoutingManager.qml 6434bff > src/apps/marble-maps/Search.qml 69ecc0a > src/apps/marble-maps/WaypointImage.qml 9b0aa01 > src/lib/marble/declarative/Routing.h a1e93c5 > src/lib/marble/declarative/Routing.cpp 38e0d66 > > Diff: https://git.reviewboard.kde.org/r/124666/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > circular_menu_backdrop.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png > place_blue.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png > delete_white.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel