> On Feb. 4, 2017, 11:30 a.m., Albert Astals Cid wrote: > > Seems this patch was not commited and does not apply anymore.
If this is something we still need, I can surely update it! - Marius ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122725/#review102370 ----------------------------------------------------------- On April 29, 2015, 4:42 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122725/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 4:42 p.m.) > > > Review request for Marble. > > > Bugs: 344237 > http://bugs.kde.org/show_bug.cgi?id=344237 > > > Repository: marble > > > Description > ------- > > The original code on copying coordinates function didn't respect the DRY > principle as it was implemented DIFFERENTLY, in two separate locations: the > Edit>Copy Coordinates action (QtMainWindow.cpp), RMB->Copy Coordinates ( > MarbleWidgetPopupMenu.cpp ) > > To solve this, I created a new specialized class > CopyCoordinatesDialog.{cpp,h,ui} which handled all the formating for the > coordinates. > This class allows the user to PREVIEW and SELECT a format for exporting > coordinates, all in a small window. The window pops up the first time a user > tries to copy coordinates, and offers the option to not show again in the > future. > > It is also possible to modify the format option in the Settings dialog(as the > window suggests). > > The following formats have been added as an option: > -Degree (DMS) (human readable) > -Degree (Decimal) (human readable) > -Universal Transverse Mercator (UTM) (human readable) > -Longitude,Latitude (machine readable) > -Latitude,Longitude (machine readable) > -Geo: URI (machine readable) > -Geo: URI with altitude (machine readable) > - > The exported object is a MimeData object composed by the following data: > - text ( the formated coordinates ) > - KML representation > - GPX representation > > > Diffs > ----- > > src/apps/marble-qt/QtMainWindow.h 595ffd2 > src/apps/marble-qt/QtMainWindow.cpp c4280c6 > src/lib/marble/CMakeLists.txt f448f84 > src/lib/marble/MarbleViewSettingsWidget.ui 43e153e > src/lib/marble/MarbleWidget.h cd3b9bf > src/lib/marble/MarbleWidget.cpp f83fcb8 > src/lib/marble/MarbleWidgetPopupMenu.cpp 6756f49 > src/lib/marble/QtMarbleConfigDialog.h 1fbee43 > src/lib/marble/QtMarbleConfigDialog.cpp ed5b62c > > Diff: https://git.reviewboard.kde.org/r/122725/diff/ > > > Testing > ------- > > was tested on master branch @ 20 feb > > > Thanks, > > Marius Stanciu > >
