Hi, Sergey! On Jun 04, Sergey Petrunya wrote: > > All of the recent 5.3 builds in buildbot have two failures: > > innodb_plugin.innodb_bug54044 'innodb_plugin' > innodb_plugin.innodb_information_schema 'innodb_plugin' > > The failure happens only with innodb_plugin. XtraDB is fine. > > I've investigated the first problem. Its cause is in > storage/xtradb/handler/ha_innodb.cc:get_innobase_type_from_mysql_type(): > > - On 2010-08-04, Kristian did a merge from XtraDB in > Percona-Server-5.1.47-11 and among everything else pulled in the code > that will produce error when the function's argument is Field_null. > This seems to be the bugfix for BUG#54044 > > - On 2011-03-29, Sergei was making fix for lp:743017 in 5.1-micro, > switched the function from analyzing field->type() to analyzing > field->key_type() and in the process removed the part of code that > Kristian has added. For some reason, he did that > storage/innodb_plugin and storage/innobase but not to storage/xtradb.
Because my patch was in mysql-5.1, there was no xtradb there :) > - On May, 28th Monty has merged in Sergei's change into 5.3-main and we > started to get the failure. > > I see two problems here: > P1: (the apparent one) Sergei's new code doesn't produce error when > passed a Field_null object. intentionally. I've fixed the test too, btw (in 5.1). > P2: (less apparent one) Why do we have Microsecond changes in > innodb_plugin but not in xtradb? Could there be more fixes missing in > a similar way? Monty merged my changes into 5.3, but missed this particular detail, so xtradb and the test case were merged incorrectly. I can fix it on Monday (hopefully). Regards, Sergei _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
