Hi, Holyfoot! On Jun 08, holyf...@askmonty.org wrote: > revision-id: 87088b91f7dfa49a1946454d347d823dab643569 > parent(s): 96b37035e4045a27f64810c2d946bad2d1453a80 > committer: Alexey Botchkov > branch nick: server > timestamp: 2015-06-08 21:44:13 +0500 > message: > > MDEV-8211 plugins.server_audit fails sporadically in buildbot. > This test also should be fixed - delay added so the connection > event doesn't happen before the query. > > --- > mysql-test/suite/plugins/t/thread_pool_server_audit.test | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mysql-test/suite/plugins/t/thread_pool_server_audit.test > b/mysql-test/suite/plugins/t/thread_pool_server_audit.test > index 1a2d729..2c749e2 100644 > --- a/mysql-test/suite/plugins/t/thread_pool_server_audit.test > +++ b/mysql-test/suite/plugins/t/thread_pool_server_audit.test > @@ -13,6 +13,7 @@ set global server_audit_incl_users=null; > set global server_audit_file_path='server_audit.log'; > set global server_audit_output_type=file; > set global server_audit_logging=on; > +--sleep 2 > connect (con1,localhost,root,,mysql); > connection default; > disconnect con1;
This is not a good idea. First, delays make mysql-test slower. And most often - unnecessary slower, as the test succeeds without a delay too. But also delays are unreliable, on a slow box two seconds may be not enough. Don't use delays, please, in this case you can wait for the query to complete before opening a new connection. Regards, Sergei _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp