On 05/04/18 19:48, Otto Kekäläinen wrote: > Hello! > > Just for the record, I've done some small tweaks to 10.3
Great work so far. > so that it now > builds perfectly and passes build tests on all Launchpad architectures > that I have access to. Needs a bit more than build tests: The use of /etc/mysql/mariadb.conf.d/ is admirable however it appears its never read (MDEV-15627). This path needs to be integrated into the build system and the executables not just a debian move files around implementation. Is the reading of /etc/mysql/my.cnf / /etc/mysql/my.conf.d desired? This path also isn't used by the system mariadb@ multi-instance service file (support-files/mari...@.service.in). The rather ugly /etc/mysql/conf.d/my%I.cnf is (sorry). A small variant to pr #510 could set MYSQLD_MULTI_INSTANCE=--defaults-file=/etc/mysql/mariadb.%I.cnf which a consistent way using the alternative configuration directories. Is there a more preferred way? Log-rotation is probably broken too afaik pid files may not exists - solution in MDEV-13050 however check both conditions if necessary. Why is /usr/include/mariadb/server/private/ installed? AFAIK there is no supported API/ABI here. /etc/mysql/conf.d/mysqld_safe_syslog.cnf assuming this is debian/additions/mysqld_safe_syslog.cnf and mysqld_safe isn't used in the a systemd environment it can be removed. debian/additions/mariadb.cnf - seems to encourage changing character set here. How about this occurs in a /etc/mysql/mariadb.conf.d/charset.cnf file? (also note header). debian-start, MDEV-14622, is also a problem. _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
