Hi! On Sat, Mar 27, 2021 at 7:14 PM Sergei Golubchik <s...@mariadb.org> wrote: > > Hi, Michael! > > On Mar 27, Michael Widenius wrote: > > revision-id: c157c285db9 (mariadb-10.5.2-514-gc157c285db9) > > parent(s): 16e38888c06 > > author: Michael Widenius <michael.widen...@gmail.com> > > committer: Michael Widenius <michael.widen...@gmail.com> > > timestamp: 2021-03-24 14:31:53 +0200 > > message: > > > > Optimize Sql_alloc > > > > - Remove 'dummy_for_valgrind' overrun marker as this doesn't help much. > > The element also distorts the sizes of objects a bit, which makes it > > harder to calculate gain in object sizes when doing size optimizations. > > - Avoid one extra call indirection when using thd_get_current_thd(), which > > is used by Sql_alloc.
<cut> > > MYSQL_THD _current_thd() { return THR_THD; } > > +THD *thd_get_current_thd() { return THR_THD; } > > I'd rather remove thd_get_current_thd() completely, why do we need two > identical functions? > > Sql_alloc can use _current_thd() just fine, I've tried (also rocksdb > uses thd_get_current_thd in one place, but it can use current_thd like > the rest of the server code). I thought that thd_get_current_thd() was an interface function for external (not server code). We have had it in since 2015 when Svoj added it. ok, I will add a patch before Optimize sql_alloc to remove it Regards, Monty _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp