Yup, obviously caused by this change:

    svn log ApacheHandler.pm
     
------------------------------------------------------------------------
    r3841 | autarch | 2007-08-27 10:26:51 -0700 (Mon, 27 Aug 2007) |  
15 lines

    Use $r->notes() to track whether or not we've sent the headers in
    ApacheHandler. This replaces the hacky of looking at and messing  
with
    $r->content_type, which doesn't play well with apps like Bricolage,
    which want to set the content_type before passing control to Mason.

The original code, which checked content_type, was designed so that  
people could call $r->send_http_header themselves. Of course it  
didn't work in other situations, as described above.

It's odd to me that we would use $r->notes, given that the only code  
that uses this is ApacheHandler.pm. Why wouldn't we get/set a flag in  
the ApacheHandler object instead? Then we could provide a

     $m->http_header_sent();

for people to call when they've called $r->send_http_header themselves.

Jon

On Oct 19, 2007, at 12:58 AM, brett gardner wrote:

> With HTML::Mason::ApacheHandler 1.69 there is a bug.
>
> If you call "$r->send_http_header" in your code, then you have to do
> "$r->notes('mason-sent-headers',1)". If you don't set the notes
> variable, then the headers are sent twice.
>
>
>
> ---------------------------------------------------------------------- 
> ---
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a  
> browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Mason-users mailing list
> Mason-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mason-users


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Mason-users mailing list
Mason-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mason-users

Reply via email to