Hi Eric,
Thanks for the feedback and your nice emacs package.
Yes, even if there are still missing features, TRAMP works really well and
I think there is not a lot of work for having almost all features of your
emacs package which work under it.
I will let you know about other patches as I come across issues.
Regards,
Julien
Le mar. 4 mai 2021 à 13:12, Eric Ludlam <ericlud...@gmail.com> a écrit :
> Hi,
>
> Thanks Julien for the patch.
>
> The nature of this patch seems good to me. The workflow of Emacs and
> MATLAB on different machines is an interesting one, and it is nice that it
> can be made to work in such a simple way!
>
> Eric
>
> On Mon, May 3, 2021 at 12:06 PM Uwe Brauer <o...@mat.ucm.es> wrote:
>
>> >>> "JCvM" == Julien Claisse via Matlab-emacs-discuss <
>> matlab-emacs-discuss@lists.sourceforge.net> writes:
>>
>> Hi Julien,
>>
>>
>> > Hi,
>> > First, thanks to the developer team for maintaining this emacs package.
>> I'm
>> > using it almost every day.
>>
>> Most of the work is done by Eric and John.
>>
>>
>> > I'm sending this mail because I want to suggest one improvement in the
>> > emacsrunregion.m matlab function for being able to use it into a tramp
>> > opened file (I'm also doing a lot of remote development on several
>> targets).
>>
>> > This improvement is relatively straightforward, it adds the following
>> lines
>> > at the beginning of the function :
>>
>> > modified toolbox/emacsrunregion.m
>> > @@ -2,6 +2,12 @@ function emacsrunregion(file, startchar, endchar)
>> > % Run code from FILE between STARTCHAR and ENDCHAR.
>> > % Command sent by Emacs for run-cell & run-region functionality.
>>
>> > + % Filter out emacs tramp file path prefix
>> > + trampMatch = regexp(file, {'/*:',':/'});
>> > + if (~isempty(trampMatch{1}))
>> > + file = file((trampMatch{2}+1):end);
>> > + end
>> > +
>> > if ~exist(file,'file')
>> > error('You must save your region into a file accessible by
>> MATLAB
>> > process.');
>> > end
>>
>> > This way, file tramp path prefixes like "/scp:host@host_ip:" are
>> filtered
>> > out and the MATLAB remote shell can find the file without any trouble.
>>
>>
>> That looks ok to me, but since this is Eric's brainchild,
>> I think he should also agree.
>>
>>
>> > How can I submit this pull request ? Do I simply need to commit and
>> push ?
>>
>> Commit and push to where?
>>
>> The main development is done in sourceforge, github is just a mirror. I
>> am not sure whether you have write access to sourceforge I rather think
>> not.
>> I not a huge fan of pull request[1] although I know most people consider
>> it
>> today as a standard.
>>
>> Once we agreed on that patch I can apply it to Master, or Eric for that
>> matter.
>>
>> Regards
>>
>> Uwe
>>
>> Footnotes:
>> [1] I prefer to discuss patches on the mailing list and then apply them
>> or to give a person write access to that he/she can push.
>>
>> _______________________________________________
>> Matlab-emacs-discuss mailing list
>> Matlab-emacs-discuss@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
>>
> _______________________________________________
> Matlab-emacs-discuss mailing list
> Matlab-emacs-discuss@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
>
--
Cordialement, Kind regards
*Julien Claisse*
Software Engineer
*Moduleus S.A.S,*
34 rue Pierre et Marie Curie
37100 Tours, France
+33 (0)2 47 49 08 16 <+33%202%2047%2049%2008%2016>
www.moduleus.com
_______________________________________________
Matlab-emacs-discuss mailing list
Matlab-emacs-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
