On Fri, Sep 12, 2008 at 2:46 PM, Jae-Joon Lee <[EMAIL PROTECTED]> wrote: > Thanks John, > > I think I'd better use a sf patch initially so that you or others can > review and improve it. I'll definitely need some help with > documentation as my English can be horrible sometime. On the other > hand, it would be much easier for me to do some maintenance work if I > can commit the changes directly. So, my sf id is "leejjoon" and it > will be great if you add me as a developer.
OK, I added you as a developer, but you continue posting your patches here and we will be happy to review and comment on them as we have time. > I guess this fancy box thing can be used with other artist objects > also, although the legend object is an only object I can think of now. > And my personal inclination is put those support code into patches.py > and have a patch class around it, i.e., a FancyBoxPatch class which is > initialized with bbox-like object and draw a fancy box around the > given bbox. And let the Text and the Legend class use this > FancyBoxPatch. In the current matplotlib, both the Text and the Legend > class uses the Patch class for drawing a bbox. So how do you think? Yes, if you can generalize it to a Patch instance this will be more useful and then matplotlib.patches will be the place for it. I notice that your current TextBoxArtist does not actually derive from matplotlib.artist.Artist. If you intend it to be an Artist, you should explictly inherit and implement draw and other required methods (eg get_children if your Artist contains other artists) > What I also want to see in matplotlib is a fancy annotation. I have > some working code (although I'm planning some major code > reorganization) and willing to contribute it if there is an interest > (see the attached example). As you can easily guess, the fancy > annotation share some of its core with the fancy box. So if you're > also willing to include the fancy annotation things in matplotlib, > I'll put some more effort in the code reorganization so that it can > nicely fit in the current matplotlib classes. These examples look very nice too! Send in a patch when you have everything organized. JDH ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
