Hi Eric,
Sorry for the late reply.
On Sep 27, 2008, at 8:56 PM, Eric Firing wrote:
> Actually, I think the most logical thing would be to let the default
> None give the old behavior, and require precision=0 to get the new
> behavior. What do you think? Is it OK if I make this change? It
> is more consistent with the old behavior.
I'm ambivalent about this change. On one hand, I think it makes a lot
more sense to have None give the old behavior and precision=0 to
ignore zero values in the sparse array (then precision would be
consistent for finite values and for zero).
On the other hand, I think ignoring zero values should be the default
behavior for sparse arrays (although, I definitely agree there should
be the option to plot all assigned values).
Would it be possible to make the change you suggest and also change
the default precision value to 0? (see diff below) This change would
also allow you to remove a lot of the special handling for
precision=None, since precision=0 gives the same result (I didn't go
this far in the diff below).
> I also changed the behavior so that if a sparse array is input, with
> no marker specifications, it simply makes a default marker plot
> instead of raising an exception.
Excellent idea. That behavior is much more user-friendly.
Thanks,
-Tony
PS. Any comments on the small changes to the examples. Both changes
are necessary for those examples to work on my computer (the shebang
line throws an error when I run the code from my text editor).
Index: matplotlib/lib/matplotlib/axes.py
===================================================================
--- matplotlib/lib/matplotlib/axes.py (revision 6141)
+++ matplotlib/lib/matplotlib/axes.py (working copy)
@@ -6648,7 +6648,7 @@
return Pxx, freqs, bins, im
- def spy(self, Z, precision=None, marker=None, markersize=None,
+ def spy(self, Z, precision=0., marker=None, markersize=None,
aspect='equal', **kwargs):
"""
call signature::
@@ -6731,14 +6731,11 @@
else:
if hasattr(Z, 'tocoo'):
c = Z.tocoo()
- if precision == 0:
+ if precision is None:
y = c.row
x = c.col
else:
- if precision is None:
- nonzero = c.data != 0.
- else:
- nonzero = np.absolute(c.data) > precision
+ nonzero = np.absolute(c.data) > precision
y = c.row[nonzero]
x = c.col[nonzero]
else:
Index: matplotlib/examples/pylab_examples/masked_demo.py
===================================================================
--- matplotlib/examples/pylab_examples/masked_demo.py (revision 6141)
+++ matplotlib/examples/pylab_examples/masked_demo.py (working copy)
@@ -1,4 +1,4 @@
-#!/bin/env python
+#!/usr/bin/env python
'''
Plot lines with points masked out.
Index: matplotlib/examples/misc/rec_groupby_demo.py
===================================================================
--- matplotlib/examples/misc/rec_groupby_demo.py (revision 6141)
+++ matplotlib/examples/misc/rec_groupby_demo.py (working copy)
@@ -2,7 +2,7 @@
import matplotlib.mlab as mlab
-r = mlab.csv2rec('data/aapl.csv')
+r = mlab.csv2rec('../data/aapl.csv')
r.sort()
def daily_return(prices):
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
