John Hunter wrote: > On Wed, Oct 8, 2008 at 10:27 PM, Erik Tollerud <[EMAIL PROTECTED]> wrote: >> Ah, that makes more sense Jae-Joon - thanks! > > Jae-Joon -- could you handle this patch submission? > > Thanks, > JDH
Hi, I also had a look at this patch -- as that's a feature I was interested in, too. There are a few things that I think need to be changed; just want to share my thoughts: - the parameter numpoints should be used (it's ignored right now) - Some private variables are accessed and a new RegularPolycollection is created (does this work eg. with a StarPolygonCollection? I haven't checked, but I don't think so !). Instead of creating a new RegularPolyCollection it might be more useful to make a copy of the existing object... I was thinking about a update_from() method for the Collection class(es) similar to update_from() for lines. mm > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
