Reinier Heeres wrote:
> Hi Philip, all,
>
> This work seems to overlap a lot with the recent color map changes I
> committed
> (http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/trunk/matplotlib/lib/matplotlib/colors.py?r1=7488&r2=7620),
> except for the piece-wise constant color maps.
Exactly. And I don't think piece-wise constant maps are a good idea, so
I oppose including a function to make them.
>
> Of course we should avoid duplicate code and work, so perhaps we can
> narrow it down to the piece-wise constant part? Please let me know
> what you think. We should definitely add a few examples of how to use
> this new code, as it might not be that clear directly. Basically the
> following is the idea:
>
> import numpy as np
> import matplotlib.colors as mcol
> import matplotlib.pyplot as plt
>
> stop = mcol.LinearSegmentedColormap.from_list('stop', ['green',
> 'orange', 'red'])
> # or: stop = mcol.LinearSegmentedColormap.from_list('stop', [(0,
> 'green'), (0.2, 'orange'), (1, 'red')])
from_list could have an API more like Phillip's, with an optional
argument for the transition points instead of using the sequence of
pairs. I'm not sure whether this is an improvement or not, but it has
some appeal to me.
One might also argue that instead of being a static method, from_list
should be renamed as a free-standing factory function in the colors
namespace. Or that such an alias be created.
Eric
>
> x = np.arange(100)
> y = x.reshape((5,20))
> plt.imshow(y, cmap=stop)
> plt.show()
>
> Beside that, I think in no part of MPL we depend on scipy explicitly,
> so it would be good to get rid of that. Also, your use of isinstance
> should be replaced by the more generic functions in cbook.py (e.g.
> is_string_like, is_numlike).
>
> Regards,
> Reinier
>
> On Sun, Oct 4, 2009 at 4:34 AM, Dr. Phillip M. Feldman
> <pfeld...@verizon.net> wrote:
>> "Create patch" worked. Thanks! The output is attached.
>>
>> http://www.nabble.com/file/p25734649/colors.py.diff colors.py.diff
>>
>>
>>> From: Dr. Phillip M. Feldman [mailto:pfeld...@verizon.net]
>>> Sent: Thursday, October 01, 2009 20:45
>>>
>>> Unfortunately, I'm on a Windows system, and it appears that I
>>> must use SVN's GUI interface, which does not provide a
>>> mechanism for saving the diff to a file.
>> Which GUI are you using? If TortoiseSVN, you right-click on the modified
>> file
>> and select "Create patch..." from the TortoiseSVN menu.
>> --
>> View this message in context:
>> http://www.nabble.com/proposed-change-to-colors.py-tp25691605p25734649.html
>> Sent from the matplotlib - devel mailing list archive at Nabble.com.
>>
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry® Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9-12, 2009. Register now!
>> http://p.sf.net/sfu/devconf
>> _______________________________________________
>> Matplotlib-devel mailing list
>> Matplotlib-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>>
>
>
>
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
