Ideally, the example would be both: 1) standalone under the examples tree so that it creates a gallery entry in the docs
2) a regression test so that testing will ensure the feature continues to work over time This isn't true of every PR, obviously, but for things that create nice new visible features it's a good rule of thumb. Mike On 06/01/2012 11:55 AM, Paul Hobson wrote: > Question about this: > > Do you want the example in the docstring of the function or just a > standalone script that you can run to verify that the PR actually > works? > (My PR will have to wait until tonight, unfortunately) > -paul > > On Fri, Jun 1, 2012 at 8:37 AM, Michael Droettboom<md...@stsci.edu> wrote: >> As you probably know, we've got a lot of pull requests in the hopper. >> Thanks to everyone who's been triaging these lately. >> >> I've just gone through and tried to add comments about what's left to be >> done with each to make them mergeable. (9 times out of 10, I'm saying >> "add an example and unit test" ;) If you submitted a PR that you feel >> is being ignored, feel free to ping those involved by adding a comment >> to the end of the PR that summarizes what issues are remaining. >> >> Mike >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Matplotlib-devel mailing list >> Matplotlib-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
