Correct, I meant that I don't see my refactor of the webagg backend affecting the refactor I have done in the main PR. I do the refactor of the core classes in https://github.com/matplotlib/matplotlib/pull/4143 and then make separate branches (which will turn into PRs once the main backend has finished) for the individual backends. For example refactoring the 2nd backend on my list (Tk) caused me to make some small adjustments to the base refactor. After then I have had no problems, so when I said ``but nothing
that breaks the main PR'', I meant it as an affirmation of that.

On 24/03/15 06:58, Achyut Rastogi wrote:
Changes made during refactors are always backwards compatible right? I just wanted to know what you mean by "breaking the main PR"?
Thank you

On Mon, Mar 23, 2015 at 10:30 PM, OceanWolf <juichenieder-n...@yahoo.co.uk <mailto:juichenieder-n...@yahoo.co.uk>> wrote:

    Just updated the MEP with more info.  From what I gather, I don't see
    any problems.  Refactoring WebAgg makes for slow progress, but nothing
    that breaks the main PR.  As far as I can tell it can get merged
    while I
    work on the other backends and submit them as separate PRs. With this
    main branch merged we can then progress/finalise MEPs 22 and 23.

    On 02/03/15 20:20, OceanWolf wrote:
    > Hi everyone,
> Over the past week or so I have been working on what I now dub MEP27
    > <https://github.com/matplotlib/matplotlib/wiki/MEP27> .  I have
    already
    > gotten quite far with it, but as I do some hefty changes (no
    breakages, and
    > virtually 100% backward compatible) I wanted to make sure I got
    some input
    > before continuing.  I have now gotten far enough to know that
    the base code
    > should work without any more tweaking.
    >
    > Best,
    > OceanWolf
    >
    >
    >
    > --
    > View this message in context:
    
http://matplotlib.1069221.n5.nabble.com/MEP-27-Backend-Refactor-Gcf-tp45032.html
    > Sent from the matplotlib - devel mailing list archive at Nabble.com.
    >
    >
    
------------------------------------------------------------------------------
    > Dive into the World of Parallel Programming The Go Parallel
    Website, sponsored
    > by Intel and developed in partnership with Slashdot Media, is
    your hub for all
    > things parallel software development, from weekly thought
    leadership blogs to
    > news, videos, case studies, tutorials and more. Take a look and
    join the
    > conversation now. http://goparallel.sourceforge.net/
    > _______________________________________________
    > Matplotlib-devel mailing list
    > Matplotlib-devel@lists.sourceforge.net
    <mailto:Matplotlib-devel@lists.sourceforge.net>
    > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


    
------------------------------------------------------------------------------
    Dive into the World of Parallel Programming The Go Parallel
    Website, sponsored
    by Intel and developed in partnership with Slashdot Media, is your
    hub for all
    things parallel software development, from weekly thought
    leadership blogs to
    news, videos, case studies, tutorials and more. Take a look and
    join the
    conversation now. http://goparallel.sourceforge.net/
    _______________________________________________
    Matplotlib-devel mailing list
    Matplotlib-devel@lists.sourceforge.net
    <mailto:Matplotlib-devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/matplotlib-devel



------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to