Hi Prabhu Prabhu Ramachandran wrote: > 1. You have mixed tabs and spaces. Please "untabify" the source > before checking it in. In general it is a good idea to use > tabnanny.py to figure out if the sources are clean of tabs. Oops - have fixed my vimrc as well as the code.
> 2. There are a few places where I disable the warnings and re-enable > them. You have removed those. Can you please add those back in. I added them back in. I previously removed them because they didn't appear to do anything. I guess they are there because of a particular vtk release. > 3. Please verify that the save/load features work properly. Tested and working. > 4. I noticed a print statement which can be removed. Duh! > Please also test it so it works correctly. I hardly use the filter so > you probably can test it better. Tested to death. I needed it as part of another filter to extract data for ArcGIS. > If the above issues are addressed I think you can go ahead and check > it in. Thanks! Done. > Yes, please have a go at v2.0 and send in your comments. I have been meaning to. I'll do that before I write any more code. There is just an inertia issue as my group and colleagues use MayaVi 1.cvs ;) Cheers g ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ MayaVi-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mayavi-users
