David Baird wrote:
On 9/9/05, Dave Howorth <[EMAIL PROTECTED]> wrote:
What's confusing me? Well first, the comment - it's ALWAYS a template
isn't it? Never a static page.

If there's an error during call_authenticate(), then error() will get
called, and at that point you might still be dealing with a static
page.

Standard Maypole never deals with static pages, does it? It always puts something into $r->template and tries to run the template processor on it. Or it dies first :) The only way static pages can be involved is if there's custom code in the application.

There are so many side-effects and so much coupling of distant methods
with each other that I've never been able to get my head around
Maypole's exception system. Either it's very clever and I don't get
it, or it's a mess that needs fixing.

I've never been able to grock it all either, and I've wasted quite a bit of time trying on various occasions. So I agree with your second option!

On this occasion, I was confused by Apache giving different format logging on a new machine and my log filter was discarding the error :( So the behaviour I got was OK. Looking again, I still think that:

  return -1 unless @{ $r->{objects} || [] };

shouldn't be there. I'll ponder on it some more.

Cheers, Dave



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Maypole-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/maypole-devel

Reply via email to