Aaron Trevena:
> catalyst, has it even nicely presented
Nah, that's abysmal. Take a look at this:
http://alibi.simon-cozens.org/~simon/tmp/maypole-error.png
Patch attached. The first four hunks should be self-explanatory. The
next hunk says that in debug mode, we try to report the error through
the view class's "report_error" mechanism if one exists. This can't be the
normal template-formatting process, because we might not have some of
the very important components (this bit me while I was developing it!) -
for instance, $view->args may well fall over. The final hunk is the template.
It's hard-coded in there so you get *something* in debug mode even if you're
not using the factory templates.
--
You are in a maze of little twisting passages, all alike.
Index: lib/Maypole.pm
===================================================================
--- lib/Maypole.pm (revision 426)
+++ lib/Maypole.pm (working copy)
@@ -515,7 +515,7 @@
if ( my $error = $@ )
{
- $status = $self->call_exception($error);
+ $status = $self->call_exception($error, "authentication");
if ( $status != OK )
{
@@ -542,7 +542,7 @@
if ( my $error = $@ )
{
- $status = $self->call_exception($error);
+ $status = $self->call_exception($error, "model");
if ( $status != OK )
{
@@ -595,7 +595,7 @@
if ( my $error = $@ )
{
- $status = $self->call_exception($error);
+ $status = $self->call_exception($error, "view");
if ( $status != OK )
{
@@ -823,16 +823,16 @@
sub call_exception
{
- my ($self, $error) = @_;
+ my ($self, $error, $when) = @_;
# Check if we have a model class with an exception() to delegate to
if ( $self->model_class && $self->model_class->can('exception') )
{
- my $status = $self->model_class->exception( $self, $error );
+ my $status = $self->model_class->exception( $self, $error, $when );
return $status if $status == OK;
}
- return $self->exception($error);
+ return $self->exception($error, $when);
}
@@ -845,7 +845,14 @@
=cut
-sub exception { return ERROR }
+sub exception {
+ my ($self, $error, $when) = @_;
+ if ($self->view_object->can("report_error") and $self->debug) {
+ $self->view_object->report_error($self, $error, $when);
+ return OK;
+ }
+ return ERROR;
+}
=item additional_data
Index: lib/Maypole/View/TT.pm
===================================================================
--- lib/Maypole/View/TT.pm (revision 426)
+++ lib/Maypole/View/TT.pm (working copy)
@@ -4,6 +4,8 @@
use Template;
use File::Spec::Functions qw(catdir tmpdir);
+our $error_template;
+{ local $/; $error_template = <DATA>; }
use strict;
our $VERSION = 2.11;
@@ -36,6 +38,27 @@
}
}
+
+sub report_error {
+ my ($self, $r, $error, $type) = @_;
+ my $output;
+ # Need to be very careful here.
+ my $tt = Template->new;
+ if ($tt->process(\$error_template,
+ { err_type => $type, error => $error,
+ config => { %{$r->{config}}},
+ request => $r, # We have that at least
+ eval{$self->vars($r)} }, \$output )) {
+ $r->{output} = $output;
+ if ($tt->error) { $r->{output} = "<html><body>Even the error template
+ errored - ".$tt->error."</body></html>"; }
+ $r->{content_type} ||= "text/html";
+ $r->{document_encoding} ||= "utf-8";
+ return OK;
+ }
+ return ERROR;
+}
+
1;
=head1 NAME
@@ -298,3 +321,50 @@
=cut
+__DATA__
+<html><head><title>Maypole error page</title>
+<style type="text/css">
+body { background-color:#7d95b5; font-family: sans-serif}
+p { background-color: #fff; padding: 5px; }
+pre { background-color: #fff; padding: 5px; border: 1px dotted black }
+h1 { color: #fff }
+h2 { color: #fff }
+.lhs {background-color: #ffd; }
+.rhs {background-color: #dff; }
+</style>
+</head> <body>
+<h1> Maypole application error </h1>
+
+<p> This application living at <code>[%request.config.uri_base%]</code>,
+[%request.config.application_name || "which is unnamed" %], has
+produced an error. The adminstrator should be able to understand
+this error message and fix the problem.</p>
+
+<h2> Some basic facts </h2>
+
+<p> The error was found in the [% err_type %] stage of processing
+the path "[% request.path %]". The error text returned was:
+</p>
+<pre>
+ [% error %]
+</pre>
+
+<h2> Request details </h2>
+
+<table>
+ [% FOR thing = ["model_class", "table", "template", "path",
+ "content_type", "document_encoding", "action", "args", "objects"] %]
+ <tr> <td class="lhs"> [%thing %] </td> <td class="rhs"> [%
+ request.$thing.list.join(" , ") %] </td></tr>
+ [% END %]
+</table>
+
+<h2> Application configuration </h2>
+<table>
+ [% FOR thing = config.keys %]
+ <tr> <td class="lhs"> [%thing %] </td> <td class="rhs"> [%
+ config.$thing.list.join(" , ") %] </td></tr>
+ [% END %]
+</table>
+</body>
+</html>
