Another thing, that would be nice in Maypoles untaint system is if you could specify the error message. I'm not sure the best place to do that. Probably not in Untaint.
Regarding Untaints inadequacies as i have said a thousand times (ignore if you've heard it before but it seems like no one agrees or disagrees with me ever when i talk about it) IMO , Untaint's main flaw is it trys to untaint empty form inputs. This is bad because it means untaint handler authors have to not give errors for empty form inputs. My logic was that Untaint should not have to worry about an empty input. Whether an empty input is valid or not is a higher level issue. IE sometimes it is ok for an integer to be empty and sometimes it is not. Sometimes it is ok for a pritable to be empty and sometimes not. Therefore all the handlers will have to behave the same on an empty field for CGI::Untaint to be cosistent. And since that is the case, Untaint can just avoid calling the handler in the first place if the field is empty and return . The other side of argument is that if you write handlers to validdate more specific fields -- ie beer-brewery-column -- Untaint no worky. Thats why tony had problem with my solution i guess. personally , i dont see much need for that specific of a handler. I will just handle it on a case by case basis on my own. In CGI::UntaintPatched -- my smart ass named module -- I chose it to return "No input for field " error. and let higher level worry about it. Better than overriding every handler. Its based on CGI::Untaint so it still needs it. Anyway, I agree that if we documented what we need, we could come up with a good system/pattern and not a bunch of different hacked sytems. and i think its time we do that. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ Maypole-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/maypole-devel
